RHELMISC-7213: Dropbox uploader create folder but does not create share folder #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostyanf14
requested changes
Jan 31, 2025
Jedoku
force-pushed
the
RHELMISC-7213-Dropbox-uploader-create-folder-but-does-not-create-share-link
branch
from
63ce935 to
431c478
Compare
akihikodaki
requested changes
Feb 5, 2025
Jedoku
force-pushed
the
RHELMISC-7213-Dropbox-uploader-create-folder-but-does-not-create-share-link
branch
from
431c478 to
3e3ceb9
Compare
kostyanf14
approved these changes
Feb 10, 2025
akihikodaki
requested changes
Feb 12, 2025
Jedoku
force-pushed
the
RHELMISC-7213-Dropbox-uploader-create-folder-but-does-not-create-share-link
branch
2 times, most recently
from
b312897 to
1f7d84c
Compare
Fix retry behavior in handle_exceptions when share_folder fails. Previously, when share_folder failed, handle_exceptions would retry the entire block, attempting to create an already existing folder. This led to unnecessary retries and potential errors. Now the operations are separated: - Folder creation has its own exception handling block - Share folder and link generation are handled separately - Prevents redundant folder creation attempts during retries This ensures cleaner retry logic and proper error handling for each operation independently. Signed-off-by: Vitalii Chulak <vitalii@daynix.com>
Jedoku
force-pushed
the
RHELMISC-7213-Dropbox-uploader-create-folder-but-does-not-create-share-link
branch
from
1f7d84c to
c389691
Compare
akihikodaki
requested changes
Feb 17, 2025
@akihikodaki I don't think this is a problem. Sharing will fail in this case too. This is more complicated to make sure that folder is created before trying to share it. What are your suggestions? |
Add a variable to tell if a folder is already created or not instead of having two |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.