Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply source compression filter in hsload #143

Closed
jreadey opened this issue Mar 31, 2023 · 1 comment
Closed

apply source compression filter in hsload #143

jreadey opened this issue Mar 31, 2023 · 1 comment

Comments

@jreadey
Copy link
Member

jreadey commented Mar 31, 2023

Currently hsload ignores the source datasets compression filter(s) and just applies whatever compression filter is given in the --compression flag.
Would seem better to use the source datasets compresssion filter if supplied. If no compression filter, use the --compression filter, and if no flag supplied, don't use compression.
Add a --nocompress flag that would have the effect of ignoring any existing filters (the current behavior)

jreadey added a commit that referenced this issue Apr 10, 2023
jreadey added a commit that referenced this issue Apr 11, 2023
@jreadey
Copy link
Member Author

jreadey commented Apr 11, 2023

Actually filters from the source file were being applied. Added an option --ignore-filters that will only apply filters given by the --compression argument (if any).

@jreadey jreadey closed this as completed Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant