Rename private headers <foo>_priv.h #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easy to distinguish what is private and what is public. Also: * Removed unused hdf/src/src.inc and mfhdf/fortran/common.inc files * Removed mfhdfi.h after moving the enum it contained to mfhdf.h
Missing stdlib.h in a lot of places
derobins
added
Component - Build
derobins
requested review from
jhendersonHDF,
byrnHDF,
lrknox,
fortnern,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala,
brtnfld and
schwehr
as code owners
derobins
commented
Feb 21, 2024
| # release_notes/RELEASE.txt, configure.in, | ||
| # and config/cmake/scripts/HDF4config.cmake. | ||
| # The paths to README.md, release_notes/RELEASE.txt, configure.ac, | ||
| # and config/cmake/scripts/HDF4config.cmake | ||
| # files are always from the directory two levels above hfile.h. | ||
| # files are always from the directory two levels above hfile_priv.h. |
There was a problem hiding this comment.
In my next PR, I plan to put the version macros in hdf.h
derobins
commented
Feb 21, 2024
| #include <string.h> | ||
|
|
||
| #include <jni.h> | ||
|
|
There was a problem hiding this comment.
I reordered the headers so they are in OS/C --> JNI --> Local order and put them outside the extern C block
byrnHDF
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easy to distinguish public v. private symbols.
Also: