Update config with nvhpc compile flags #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
Component - Build
byrnHDF
requested review from
lrknox,
derobins,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala,
brtnfld and
schwehr
as code owners
derobins
reviewed
Feb 26, 2024
| # asserts and other library debug code. Compiling with -O1 also does not appear | ||
| # to have these issues, so set maximum optimization level to -O1 for now until | ||
| # it can be determined whether these issues are compiler-specific or issues | ||
| # in the library. |
There was a problem hiding this comment.
You shouldn't need this in HDF4. That bug is probably HDF5-specific.
derobins
reviewed
Feb 26, 2024
| DEBUG_CFLAGS="-g -Mbounds" | ||
| DEBUG_CPPFLAGS= | ||
| #PROD_CFLAGS="-fast" | ||
| PROD_CFLAGS="" # -fast implies -O2 and -O2+ currently has test failures. |
There was a problem hiding this comment.
Probably don't need to sweat higher optimization in the Autotools due to the HDF5 bug, either
There was a problem hiding this comment.
Just keeping it consistent with the othe files
lrknox
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.