Remove the NetCDF 2.3.2 API #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests the NetCDF 2.3.2 API, which is being removed.
These are all unused in the current library.
These are neither used nor exported
* Removes NetCDF ftest program * Removes netcdf.inc * Removes jackets.c
* Both CMake and Autotools
No longer used now that cdftest.c is gone
This header is no longer generated from a .in template
Also some minor other header/CMake cleanup
The functionality was moved into hdf4_netcdf.h
The functionality was moved to nc_priv.h. The fill value constants were retained in the public API and moved to mfhdf.h.
Also changes the HNAME prefix from sd_ to H4_
derobins
added
Component - Build
derobins
requested review from
jhendersonHDF,
byrnHDF,
lrknox,
fortnern,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala,
brtnfld and
schwehr
as code owners
|
I would get inputs from Kent and Joe, and maybe Aleksandar on this. |
I've asked everyone I can think of, and nobody uses the NetCDF API we export and I've been announcing this for years. It's also not even documented. Anyone who is using our NetCDF interface can always use 4.3.0. |
bmribler
approved these changes
Oct 7, 2024
byrnHDF
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From both Fortran and C
See the RELEASE.txt note for a full description of the changes.