Modern C++ dtor declarations (#1830)

* C++ dtor modernization

- Replaced a bunch of empty dtors with `= default`
- Removed deprecated `throw()`. In C++11, dtors are `noexcept` by default.

*

c++/src/H5AbstractDs.cpp

@@ -316,12 +316,4 @@ AbstractDs::getVarLenType() const
     }
 }
 
-//--------------------------------------------------------------------------
-// Function:    AbstractDs destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-AbstractDs::~AbstractDs()
-{
-}
-
 } // namespace H5

c++/src/H5AbstractDs.h

@@ -67,7 +67,7 @@ class H5_DLLCPP AbstractDs {
     virtual H5std_string fromClass() const = 0;
 
     // Destructor
-    virtual ~AbstractDs();
+    virtual ~AbstractDs() = default;
 
   protected:
     // Default constructor

c++/src/H5ArrayType.cpp

@@ -199,12 +199,4 @@ ArrayType::getArrayDims(hsize_t *dims) const
     return (ndims);
 }
 
-//--------------------------------------------------------------------------
-// Function:    ArrayType destructor
-///\brief       Properly terminates access to this array datatype.
-//--------------------------------------------------------------------------
-ArrayType::~ArrayType()
-{
-}
-
 } // namespace H5

c++/src/H5ArrayType.h

@@ -60,7 +60,7 @@ class H5_DLLCPP ArrayType : public DataType {
     ArrayType(const hid_t existing_id);
 
     // Noop destructor
-    virtual ~ArrayType() override;
+    virtual ~ArrayType() override = default;
 
     // Default constructor
     ArrayType();

c++/src/H5AtomType.cpp

@@ -276,14 +276,4 @@ AtomType::setPad(H5T_pad_t lsb, H5T_pad_t msb) const
     }
 }
 
-#ifndef DOXYGEN_SHOULD_SKIP_THIS
-//--------------------------------------------------------------------------
-// Function:    AtomType destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-AtomType::~AtomType()
-{
-}
-#endif // DOXYGEN_SHOULD_SKIP_THIS
-
 } // namespace H5

c++/src/H5AtomType.h

@@ -67,7 +67,7 @@ class H5_DLLCPP AtomType : public DataType {
     AtomType(const AtomType &original);
 
     // Noop destructor
-    virtual ~AtomType() override;
+    virtual ~AtomType() override = default;
 #endif // DOXYGEN_SHOULD_SKIP_THIS
 
   protected:

c++/src/H5CommonFG.cpp

@@ -342,14 +342,6 @@ CommonFG::CommonFG()
 {
 }
 
-//--------------------------------------------------------------------------
-// Function:    CommonFG destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-CommonFG::~CommonFG()
-{
-}
-
 //--------------------------------------------------------------------------
 // Function:    f_DataType_setId - friend
 // Purpose:     This function is friend to class H5::DataType so that it

c++/src/H5CommonFG.h

@@ -72,7 +72,7 @@ class H5_DLLCPP CommonFG {
     CommonFG();
 
     // Noop destructor.
-    virtual ~CommonFG();
+    virtual ~CommonFG() = default;
 
   protected:
     virtual void p_setId(const hid_t new_id) = 0;

c++/src/H5CompType.cpp

@@ -527,12 +527,4 @@ CompType::setSize(size_t size) const
     }
 }
 
-//--------------------------------------------------------------------------
-// Function:    CompType destructor
-///\brief       Properly terminates access to this compound datatype.
-//--------------------------------------------------------------------------
-CompType::~CompType()
-{
-}
-
 } // namespace H5

c++/src/H5CompType.h

@@ -113,7 +113,7 @@ class H5_DLLCPP CompType : public DataType {
     }
 
     // Noop destructor.
-    virtual ~CompType() override;
+    virtual ~CompType() override = default;
 
   private:
     // Contains common code that is used by the member functions

c++/src/H5DaccProp.cpp

@@ -153,12 +153,4 @@ DSetAccPropList::getChunkCache(size_t &rdcc_nslots, size_t &rdcc_nbytes, double
     }
 }
 
-//--------------------------------------------------------------------------
-// Function:    DSetAccPropList destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-DSetAccPropList::~DSetAccPropList()
-{
-}
-
 } // namespace H5

c++/src/H5DaccProp.h

@@ -50,7 +50,7 @@ class H5_DLLCPP DSetAccPropList : public LinkAccPropList {
     DSetAccPropList(const hid_t plist_id);
 
     // Noop destructor.
-    virtual ~DSetAccPropList() override;
+    virtual ~DSetAccPropList() override = default;
 
 #ifndef DOXYGEN_SHOULD_SKIP_THIS
 

c++/src/H5DcreatProp.cpp

@@ -754,12 +754,4 @@ DSetCreatPropList::setVirtual(const DataSpace &vspace, const H5std_string src_fn
     setVirtual(vspace, src_fname.c_str(), src_dsname.c_str(), sspace);
 }
 
-//--------------------------------------------------------------------------
-// Function:    DSetCreatPropList destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-DSetCreatPropList::~DSetCreatPropList()
-{
-}
-
 } // namespace H5

c++/src/H5DcreatProp.h

@@ -140,7 +140,7 @@ class H5_DLLCPP DSetCreatPropList : public ObjCreatPropList {
     DSetCreatPropList(const hid_t plist_id);
 
     // Noop destructor.
-    virtual ~DSetCreatPropList() override;
+    virtual ~DSetCreatPropList() override = default;
 
 #ifndef DOXYGEN_SHOULD_SKIP_THIS
 

c++/src/H5DxferProp.cpp

@@ -527,12 +527,4 @@ DSetMemXferPropList::getEDCCheck() const
     return (check);
 }
 
-//--------------------------------------------------------------------------
-// Function:    DSetMemXferPropList destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-DSetMemXferPropList::~DSetMemXferPropList()
-{
-}
-
 } // namespace H5

c++/src/H5DxferProp.h

@@ -112,7 +112,7 @@ class H5_DLLCPP DSetMemXferPropList : public PropList {
     DSetMemXferPropList(const hid_t plist_id);
 
     // Noop destructor
-    virtual ~DSetMemXferPropList() override;
+    virtual ~DSetMemXferPropList() override = default;
 
 #ifndef DOXYGEN_SHOULD_SKIP_THIS
 

c++/src/H5EnumType.cpp

@@ -317,12 +317,4 @@ EnumType::getMemberValue(unsigned memb_no, void *value) const
     }
 }
 
-//--------------------------------------------------------------------------
-// Function:    EnumType destructor
-///\brief       Properly terminates access to this enum datatype.
-//--------------------------------------------------------------------------
-EnumType::~EnumType()
-{
-}
-
 } // namespace H5

c++/src/H5EnumType.h

@@ -81,7 +81,7 @@ class H5_DLLCPP EnumType : public DataType {
     // Copy constructor: same as the original EnumType.
     EnumType(const EnumType &original);
 
-    virtual ~EnumType() override;
+    virtual ~EnumType() override = default;
 
 }; // end of EnumType
 } // namespace H5

c++/src/H5Exception.cpp

@@ -330,14 +330,6 @@ Exception::printErrorStack(FILE *stream, hid_t err_stack)
 //    Exception::printErrorStack(stream, H5E_DEFAULT);
 //}
 
-//--------------------------------------------------------------------------
-// Function:    Exception destructor
-///\brief       Noop destructor
-//--------------------------------------------------------------------------
-Exception::~Exception() throw()
-{
-}
-
 //--------------------------------------------------------------------------
 // Subclass:    FileIException
 //--------------------------------------------------------------------------
@@ -359,13 +351,6 @@ FileIException::FileIException(const H5std_string &func, const H5std_string &mes
     : Exception(func, message)
 {
 }
-//--------------------------------------------------------------------------
-// Function:    FileIException destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-FileIException::~FileIException() throw()
-{
-}
 
 //--------------------------------------------------------------------------
 // Subclass:    GroupIException
@@ -388,14 +373,6 @@ GroupIException::GroupIException(const H5std_string &func, const H5std_string &m
     : Exception(func, message)
 {
 }
-//--------------------------------------------------------------------------
-// Function:    GroupIException destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-GroupIException::~GroupIException() throw()
-{
-}
-
 //--------------------------------------------------------------------------
 // Subclass:    DataSpaceIException
 //--------------------------------------------------------------------------
@@ -417,13 +394,6 @@ DataSpaceIException::DataSpaceIException(const H5std_string &func, const H5std_s
     : Exception(func, message)
 {
 }
-//--------------------------------------------------------------------------
-// Function:    DataSpaceIException destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-DataSpaceIException::~DataSpaceIException() throw()
-{
-}
 
 //--------------------------------------------------------------------------
 // Subclass:    DataTypeIException
@@ -446,13 +416,6 @@ DataTypeIException::DataTypeIException(const H5std_string &func, const H5std_str
     : Exception(func, message)
 {
 }
-//--------------------------------------------------------------------------
-// Function:    DataTypeIException destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-DataTypeIException::~DataTypeIException() throw()
-{
-}
 
 //--------------------------------------------------------------------------
 // Subclass:    ObjHeaderIException
@@ -475,13 +438,6 @@ ObjHeaderIException::ObjHeaderIException(const H5std_string &func, const H5std_s
     : Exception(func, message)
 {
 }
-//--------------------------------------------------------------------------
-// Function:    ObjHeaderIException destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-ObjHeaderIException::~ObjHeaderIException() throw()
-{
-}
 
 //--------------------------------------------------------------------------
 // Subclass:    PropListIException
@@ -504,13 +460,6 @@ PropListIException::PropListIException(const H5std_string &func, const H5std_str
     : Exception(func, message)
 {
 }
-//--------------------------------------------------------------------------
-// Function:    PropListIException destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-PropListIException::~PropListIException() throw()
-{
-}
 
 //--------------------------------------------------------------------------
 // Subclass:    DataSetIException
@@ -533,13 +482,6 @@ DataSetIException::DataSetIException(const H5std_string &func, const H5std_strin
     : Exception(func, message)
 {
 }
-//--------------------------------------------------------------------------
-// Function:    DataSetIException destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-DataSetIException::~DataSetIException() throw()
-{
-}
 
 //--------------------------------------------------------------------------
 // Subclass:    AttributeIException
@@ -562,13 +504,6 @@ AttributeIException::AttributeIException(const H5std_string &func, const H5std_s
     : Exception(func, message)
 {
 }
-//--------------------------------------------------------------------------
-// Function:    AttributeIException destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-AttributeIException::~AttributeIException() throw()
-{
-}
 
 //--------------------------------------------------------------------------
 // Subclass:    ReferenceException
@@ -591,13 +526,6 @@ ReferenceException::ReferenceException(const H5std_string &func, const H5std_str
     : Exception(func, message)
 {
 }
-//--------------------------------------------------------------------------
-// Function:    ReferenceException destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-ReferenceException::~ReferenceException() throw()
-{
-}
 
 //--------------------------------------------------------------------------
 // Subclass:    LibraryIException
@@ -620,13 +548,6 @@ LibraryIException::LibraryIException(const H5std_string &func, const H5std_strin
     : Exception(func, message)
 {
 }
-//--------------------------------------------------------------------------
-// Function:    LibraryIException destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-LibraryIException::~LibraryIException() throw()
-{
-}
 
 //--------------------------------------------------------------------------
 // Subclass:    LocationException
@@ -649,13 +570,6 @@ LocationException::LocationException(const H5std_string &func, const H5std_strin
     : Exception(func, message)
 {
 }
-//--------------------------------------------------------------------------
-// Function:    LocationException destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-LocationException::~LocationException() throw()
-{
-}
 
 //--------------------------------------------------------------------------
 // Subclass:    IdComponentException
@@ -678,12 +592,5 @@ IdComponentException::IdComponentException(const H5std_string &func, const H5std
     : Exception(func, message)
 {
 }
-//--------------------------------------------------------------------------
-// Function:    IdComponentException destructor
-///\brief       Noop destructor.
-//--------------------------------------------------------------------------
-IdComponentException::~IdComponentException() throw()
-{
-}
 
 } // namespace H5