Fixed Spelling Errors #1166

brtnfld · 2021-11-05T19:58:28Z

Fixed all spelling errors caught with codespell, added new spell checker to github actions to detect spelling errors.

…debug rw debugging

byrnHDF · 2021-11-11T15:23:09Z

test/dt_arith.c

@@ -3326,7 +3326,7 @@ test_conv_flt_1(const char *name, int run_test, hid_t src, hid_t dst)
                HDputs("    maximum failures reached, aborting test...");
            else if (run_test == TEST_DENORM || run_test == TEST_SPECIAL)
                HDputs("    maximum warnings reached, aborting test...");
-            HDputs("    (dst is library's conversion output. ans is compiler's conversion output.)");
+            HDputs("    (dst is library's conversion output. and is compiler's conversion output.)");


still needs fixed

byrnHDF

Still some fixes needed

brtnfld · 2021-11-11T16:06:45Z

Still some fixes needed

Can you be more specific?

byrnHDF · 2021-11-11T16:15:28Z

Still some fixes needed

Can you be more specific?

test/dt_arith.c - did all the "ans" to "and" issues get fixed?
tools/src/h5import/h5import.h - did the define "FILENAM" get fixed.

Sorry, but I can't seem to discover that in the changes view.

brtnfld · 2021-11-11T16:18:24Z

Still some fixes needed

Can you be more specific?

test/dt_arith.c - did all the "ans" to "and" issues get fixed?

yes

tools/src/h5import/h5import.h - did the define "FILENAM" get fixed.

I reverted the change, it is still FILNAME.

Sorry, but I can't seem to discover that in the changes view.

brtnfld · 2021-11-23T14:42:10Z

@lrknox What is remaining for this PR? I would rather not have to keep syncing this branch.

byrnHDF

I finally got the correct view of the files - looks better

derobins · 2021-12-06T22:33:55Z

src/H5C.c

@@ -1484,7 +1484,7 @@ H5C_insert_entry(H5F_t *f, const H5C_class_t *type, haddr_t addr, void *thing, u
         * Finally, we usually don't check to see if the cache is
         * oversized at the end of an unprotect.  As a result, it is
         * possible to have a vastly oversized cache with no protected
-         * entries as long as all the protects preceed the unprotects.
+         * entries as long as all the protects proceed the unprotects.


This should be precede

derobins · 2021-12-06T22:34:06Z

src/H5C.c

@@ -2444,7 +2444,7 @@ H5C_protect(H5F_t *f, const H5C_class_t *type, haddr_t addr, void *udata, unsign
             * Finally, we usually don't check to see if the cache is
             * oversized at the end of an unprotect.  As a result, it is
             * possible to have a vastly oversized cache with no protected
-             * entries as long as all the protects preceed the unprotects.
+             * entries as long as all the protects proceed the unprotects.


src/H5Cprivate.h

derobins · 2021-12-06T23:49:46Z

fortran/test/tH5A_1_8.F90

@@ -777,7 +777,7 @@ SUBROUTINE test_attr_info_by_idx(new_format, fcpl, fapl, total_error)
  INTEGER :: Input1
  INTEGER(HSIZE_T) :: hzero = 0_HSIZE_T
  INTEGER :: minusone = -1
-  INTEGER(HSIZE_T) :: htmp
+  INTEGER(HSIZE_T) :: html


This is not a typo. htmp is "temporary h", not HTML. Maybe rename it h_temp?

derobins · 2021-12-06T23:54:28Z

.github/workflows/codespell.yml

+      - uses: codespell-project/actions-codespell@master
+        with:
+          skip: ./bin/trace,./hl/tools/h5watch/h5watch.c,./tools/test/h5jam/tellub.c
+          ignore_words_list: isnt,inout,nd,parms,parm,ba,offsetP,ser,ois,had,fiter,fo,clude,refere,minnum,offsetp,creat,ans:,eiter,lastr,minum,ans,isn't,ifset,sur,trun,dne,tthe,hda,filname,te,htmp


I'm not a fan of running this automatically. There were several instances of the spell checker making mistakes in this PR, some of which were in actual code and not comments.

I disagree, the false positives are relatively low. It should be checked as part of the PR, if it becomes a major issue then we can revisit it.

FWIW the action doesn't do anything (like fix things) by default aside from fail if it finds typos. I run it on a number of repos and it doesn't often flag new false positives and when it does it's easy enough to add them to the ignore or skip lists as appropriate.

* Revert "Revert H5Dchunk_iter changes in hdf5_1_12_1 (#733)" This reverts commit 10abe9a. * Apply clang-format * Reincorporate spelling fix from #1166 * Incorporate H5Dchunk_iter changes from #161 * Backport to 1.12: Adds a quick for for some egregious chunk_info badness (#722) * Backport to 1.12: Converts testhdf5 macros to h5test macros in chunk_info.c (#1820) The two macro schemes were not designed to work together. Also quiets some MSVC warnings about comparing pointers and integers. * Backport to 1.12: H5Dchunk_iter now passes offsets in units of dataset elements, fix #1419 (#1969) * H5Dchunk_iter now passes chunk dimension scaled offsets, fix #1419 * Update docs for H5Dchunk_iter, H5Dget_chunk_info* Modified description for `H5Dchunk_iter`, `H5Dget_chunk_info`, and `H5Dget_chunk_info_by_coord` to the following * offset Logical position of the chunk’s first element in units of dataset elements * filter_mask Bitmask indicating the filters used when the chunk was written * size Chunk size in bytes, 0 if the chunk does not exist * Sync H5Dchunk_iter documentation with develop * Remove H5VL_DATASET_WAIT references from 1.12 * Backport to 1.12 #161, #1474, review comments Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>

brtnfld and others added 30 commits February 3, 2021 11:19

fixed missed closing of a dataset

b67893f

fixed missed closing of a dataset

e5b8c8b

Merge remote-tracking branch 'upstream/develop' into develop

e0e0163

Merge remote-tracking branch 'upstream/develop' into develop

268638f

fixed typo in error return

c20acc1

Merge remote-tracking branch 'upstream/develop' into develop

a920bdc

Merge remote-tracking branch 'upstream/develop' into develop

91d6bcb

Committing clang-format changes

0550cbb

minor edits

8a42502

Merge branch 'develop' of https://github.com/brtnfld/hdf5 into develop

5a85e97

code format

ee3f29f

Committing clang-format changes

50f0b26

code format

d2d7386

Merge branch 'develop' of https://github.com/brtnfld/hdf5 into develop

b94a0fa

minor edit

8bd1e8e

Merge remote-tracking branch 'upstream/develop' into develop

c9c62ed

Merge remote-tracking branch 'upstream/develop' into develop

9c7f8d2

switched from using MPI_count, to actual bytes written for H5FD_mpio_…

00a88df

…debug rw debugging

Committing clang-format changes

7c22adb

changed size_i in printf to reflect the I/O.

5cd709f

Merge branch 'develop' of https://github.com/brtnfld/hdf5 into develop

08204c4

Committing clang-format changes

64909d1

Merge remote-tracking branch 'upstream/develop' into develop

3095756

Merge remote-tracking branch 'upstream/develop' into develop

da2f96e

Fixed seg fault with xlf on BE with -qintsize=8

ce7699d

Merge remote-tracking branch 'upstream/develop' into develop

ed93ad8

Merge remote-tracking branch 'upstream/develop' into develop

d0ba058

Merge branch 'develop' of https://github.com/brtnfld/hdf5 into develop

8e63d32

Merge remote-tracking branch 'upstream/develop' into develop

a762435

fixed error function string

8a6de0f

byrnHDF reviewed Nov 11, 2021

View reviewed changes

misc.

b2b73fc

brtnfld added 3 commits November 11, 2021 10:31

misc.

1168647

Merge remote-tracking branch 'upstream/develop' into develop

7d09756

Merge remote-tracking branch 'upstream/develop' into develop

f5b3238

brtnfld added 2 commits November 23, 2021 08:50

Merge branch 'develop' into sp

880d63a

fixed more sp errors

e3bef4c

byrnHDF approved these changes Nov 23, 2021

View reviewed changes

lrknox approved these changes Dec 3, 2021

View reviewed changes

lrknox added 2 commits December 3, 2021 09:30

Merge branch 'develop' into sp

3ba9d12

Fix new typos found by codespell.

ece9954

derobins reviewed Dec 6, 2021

View reviewed changes

src/H5Cprivate.h Outdated Show resolved Hide resolved

derobins reviewed Dec 6, 2021

View reviewed changes

src/H5Cprivate.h Outdated Show resolved Hide resolved

fixed proceed with precede

7a7fcf0

derobins reviewed Dec 6, 2021

View reviewed changes

brtnfld added 3 commits December 6, 2021 18:22

fixed variable in fortran test

ed1bd26

fixed minnum

b138abe

updated spelling list

83e62d8

derobins approved these changes Dec 7, 2021

View reviewed changes

lrknox merged commit f859cb7 into HDFGroup:develop Dec 7, 2021

mkitti added a commit to mkitti/hdf5 that referenced this pull request Aug 5, 2022

Reincorporate spelling fix from HDFGroup#1166

4c07808

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed Spelling Errors #1166

Fixed Spelling Errors #1166

brtnfld commented Nov 5, 2021

byrnHDF Nov 11, 2021

byrnHDF left a comment

brtnfld commented Nov 11, 2021

byrnHDF commented Nov 11, 2021

brtnfld commented Nov 11, 2021 •

edited

Loading

brtnfld commented Nov 23, 2021 •

edited

Loading

byrnHDF left a comment

derobins Dec 6, 2021

derobins Dec 6, 2021

derobins Dec 6, 2021

derobins Dec 6, 2021

derobins Dec 6, 2021

brtnfld Dec 7, 2021

peternewman Dec 7, 2021

Fixed Spelling Errors #1166

Fixed Spelling Errors #1166

Conversation

brtnfld commented Nov 5, 2021

Choose a reason for hiding this comment

byrnHDF left a comment

Choose a reason for hiding this comment

brtnfld commented Nov 11, 2021

byrnHDF commented Nov 11, 2021

brtnfld commented Nov 11, 2021 • edited Loading

brtnfld commented Nov 23, 2021 • edited Loading

byrnHDF left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brtnfld commented Nov 11, 2021 •

edited

Loading

brtnfld commented Nov 23, 2021 •

edited

Loading