Fix a few issues noted by LGTM #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhendersonHDF
requested review from
bmribler,
byrnHDF,
ChristopherHogan,
derobins,
fortnern,
gnuoyd,
jrmainzer,
qkoziol,
soumagne and
vchoi-hdfgroup
as code owners
jhendersonHDF
commented
Feb 3, 2022
| @@ -1318,7 +1318,7 @@ attr_search(hid_t oid, const char *attr_name, const H5A_info_t H5_ATTR_UNUSED *a | |||
| j = (int)HDstrlen(op_name) - 1; | |||
| /* find the last / */ | |||
| while (j >= 0) { | |||
| if (op_name[j] == '/' && (j == 0 || (j > 0 && op_name[j - 1] != '\\'))) | |||
| if (op_name[j] == '/' && (j == 0 || (op_name[j - 1] != '\\'))) | |||
There was a problem hiding this comment.
LGTM noticed the previous checks of while (j >= 0) and if (... (j == 0 ...) make the j > 0 check redundant.
jhendersonHDF
commented
Feb 3, 2022
| unsigned long val = *(unsigned int *)buf + (i * sizeof(unsigned int)); | ||
|
|
||
| H5_CHECK_OVERFLOW(val, unsigned long, unsigned); | ||
| h5tools_str_append(&buffer, "%x ", (unsigned)val); |
There was a problem hiding this comment.
%x specifier takes an unsigned int, but the arithmetic results in an unsigned long. Convert to unsigned after overflow check.
jhendersonHDF
force-pushed
the
warnings_fixes
branch
from
f4957ad to
208d9db
Compare
byrnHDF
approved these changes
Feb 4, 2022
brtnfld
approved these changes
Feb 4, 2022
lrknox
approved these changes
Feb 4, 2022
jhendersonHDF
added a commit
to jhendersonHDF/hdf5
that referenced
this pull request
Mar 25, 2022
lrknox
pushed a commit
that referenced
this pull request
Mar 25, 2022
* Use internal version of H5Eprint2 to avoid possible stack overflow (#661) * Add support for parallel filters to h5repack (#832) * Allow parallel filters feature for comm size of 1 (#840) * Avoid popping API context when one wasn't pushed (#848) * Fix several warnings (#720) * Don't allow H5Pset(get)_all_coll_metadata_ops for DXPLs (#1201) * Fix free list tracking and cleanup cast alignment warnings (#1288) * Fix free list tracking and cleanup cast alignment warnings * Add free list tracking code to H5FL 'arr' routines * Fix usage of several HDfprintf format specifiers after HDfprintf removal (#1324) * Use appropriate printf format specifiers for haddr_t and hsize_t types directly (#1340) * Fix H5ACmpio dirty bytes creation debugging (#1357) * Fix documentation for H5D_space_status_t enum values (#1372) * Parallel rank0 deadlock fixes (#1183) * Fix several places where rank 0 can skip past collective MPI operations on failure * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Fix a few issues noted by LGTM (#1421) * Fix cache sanity checking code by moving functions to wider scope (#1435) * Fix metadata cache bug when resizing a pinned/protected entry (v2) (#1463) * Disable memory alloc sanity checks by default for Autotools debug builds (#1468) * Committing clang-format changes Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
jhendersonHDF
added a commit
to jhendersonHDF/hdf5
that referenced
this pull request
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://lgtm.com/projects/g/HDFGroup/hdf5/?mode=list