Hdf5 1 8 comment whitespace #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
requested review from
derobins,
fortnern,
jhendersonHDF,
qkoziol,
soumagne,
vchoi-hdfgroup and
jrmainzer
as code owners
lrknox
reviewed
Oct 5, 2020
| * | ||
| * Programmer: Quincey Koziol <koziol@ncsa.uiuc.edu> | ||
| * September 29, 2000 | ||
| * Programmer: Quincey Koziol <koziol@ncsa.uiuc.edu> |
There was a problem hiding this comment.
The 1.8 branch didn't get cleaned like 1.10/1.12/develop did, though (1.10 might not be complete yet).
There was a problem hiding this comment.
Well, yes, but I think it should be done in a coordinated fashion. I.E. I have a 1.12 test PR coming, that will fix the windows error but removes the email and fixes whitespace in comments just for the test dir. This made it real clear as to the actual files that had actual changes.
There was a problem hiding this comment.
Right. I wouldn't lose sleep over the email addresses in this branch.
There was a problem hiding this comment.
Hopefully by the end of the week we can have all the branches aligned, because it makes comparison between branches so easy now.
derobins
approved these changes
Oct 5, 2020
lrknox
approved these changes
Oct 5, 2020
Closed
mattjala
added a commit
to mattjala/hdf5
that referenced
this pull request
Dec 4, 2024
Fix error stack test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus test script change
Change '==' to 'eq' in test script