11099 Add help text line #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrknox
reviewed
Jan 14, 2021
| @@ -136,6 +136,7 @@ usage: h5repack [OPTIONS] file1 file2 | |||
| UD=<filter_number,filter_flag,cd_value_count,value1[,value2,...,valueN]> | |||
| Required values: filter_number, filter_flag, cd_value_count, value1 | |||
| Optional values: value2 to valueN | |||
| filter_flag: 1 is OPTIONAL or 0 is MANDATORY | |||
There was a problem hiding this comment.
I assume (or guess) that filter_flag 1 means filter is optional and 0 means filter is mandatory? If so, maybe adding 'filter' would make the meaning clearer:
filter_flag: 1 filter is OPTIONAL or 0 filter is MANDATORY
There was a problem hiding this comment.
There is more then can be explained in the help text - this just indicates what the value is to what the flag name is.
lrknox
approved these changes
Jan 15, 2021
bmribler
approved these changes
Jan 15, 2021
jhendersonHDF
pushed a commit
to jhendersonHDF/hdf5
that referenced
this pull request
Jan 20, 2021
* OESS-98 convert plugin option to FetchContent, add tests * Fixes for pkcfg files because of plugin option * OESS-98 fix tools test for plugins * Keep doxygen comments under 100 chars long - format hint * Whitespace * HDFFV-11144 - Reclassify CMake messages * HDFFV-11099/11100 added help text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.