Add bug note to H5Dget_space_status documentation (#2788) #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhendersonHDF
added
Merge
jhendersonHDF
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
bmribler
reviewed
Apr 27, 2023
src/H5Dpublic.h
Outdated
| @@ -423,6 +423,20 @@ H5_DLL hid_t H5Dget_space(hid_t dset_id); | |||
| * \details H5Dget_space_status() determines whether space has been allocated | |||
| * for the dataset \p dset_id. | |||
| * | |||
| * \note \Bold{BUG:} Prior to the HDF5 1.13.1, 1.12.2 and 1.10.9 releases, | |||
There was a problem hiding this comment.
I thought we treat 1.13.x as if they never exist...
There was a problem hiding this comment.
That's true, although changing this to 1.14.0 would be slightly inaccurate. I've also seen 1.13 releases being used in the wild, which complicates documenting this a bit as well.
byrnHDF
approved these changes
Apr 27, 2023
jhendersonHDF
force-pushed
the
H5Dget_space_status_1_10
branch
from
4dcd962 to
39530c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.