Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NVHPC [set_but_not_used] warning. #3583

Closed
wants to merge 1 commit into from
Closed

Remove NVHPC [set_but_not_used] warning. #3583

wants to merge 1 commit into from

Conversation

hyoklee
Copy link
Member

@hyoklee hyoklee commented Sep 23, 2023

This PR will remove the following NVHPC warning:

warning: variable "env_value" was set but never used [set_but_not_used]

@vchoi-hdfgroup vchoi-hdfgroup added Component - Build CMake, Autotools Component - C Library Core C library issues (usually in the src directory) Component - Testing Code in test or testpar directories, GitHub workflows and removed Component - C Library Core C library issues (usually in the src directory) labels Sep 25, 2023
byrnHDF
byrnHDF reviewed Sep 25, 2023
View reviewed changes
testpar/t_subfiling_vfd.c
@@ -2347,7 +2347,8 @@ main(int argc, char **argv)
must_unset_ioc_thread_count_env = true;
}

if (!(env_value = HDgetenv(H5FD_SUBFILING_CONFIG_FILE_PREFIX))) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If env_value is not used anywhere else just remove "env_value=" part?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that would be the correct fix here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also looks like env_value is no longer used outside of this one spot, so the variable can be removed.

@vchoi-hdfgroup vchoi-hdfgroup added the Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. label Sep 25, 2023
hyoklee added a commit to hyoklee/hdf5 that referenced this pull request Sep 25, 2023
@hyoklee
Address @byrnHDF review from PR HDFGroup#3583
6c9ef47
@hyoklee hyoklee closed this Sep 25, 2023
@hyoklee
Copy link
Member Author

hyoklee commented Sep 25, 2023

See #3590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrnHDF byrnHDF byrnHDF left review comments

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - Build CMake, Autotools Component - Testing Code in test or testpar directories, GitHub workflows Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hyoklee @jhendersonHDF @byrnHDF @vchoi-hdfgroup