-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve MPI-I/O file hints when fapl is closed #3755
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8f93a2c
Fix for issue #3025: Save the MPI info in the file struct so H5Fget_a…
vchoi-hdfgroup 3dec7d5
Committing clang-format changes
github-actions[bot] 84fd36f
Merge branch 'HDFGroup:develop' into issue_3025
vchoi-hdfgroup aa6ccbe
Merge branch 'HDFGroup:develop' into issue_3025
vchoi-hdfgroup 833c6b8
Modifications based on PR review comments: close MPI info when closin…
vchoi-hdfgroup 2806b3f
Modifications based on PR review comments: initialize mpi_info field …
vchoi-hdfgroup 2fa841d
Merge branch 'develop' into issue_3025
jhendersonHDF 7964b98
Merge branch 'HDFGroup:develop' into issue_3025
vchoi-hdfgroup 6bf3647
Modifications based on PR review comments: verify the key and value r…
vchoi-hdfgroup e5fa4eb
Committing clang-format changes
github-actions[bot] 38db446
Modification based on PR review comments: get the # of keys and loop …
vchoi-hdfgroup 99da0e6
Committing clang-format changes
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these changes are fine, but there's a possibility this test may fail depending on whether MPI keys come exactly in the order they were set on the Info object. Otherwise, the MPI I/O VFD has code to get any info set by the MPI implementation after an MPI_File_open call and then set that back on the FAPL (https://github.com/HDFGroup/hdf5/blob/develop/src/H5FDmpio.c#L892-L934)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be best to call MPI_Info_get_nkeys and then loop through all the keys, checking to see if any of them match the hint we set here and then failing if none match
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change that based on MPI_Info_get_nkeys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done