Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clarification for current behavior of H5Get_objtype_by_idx() #4120

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Add clarification for current behavior of H5Get_objtype_by_idx() #4120

merged 3 commits into from
Mar 22, 2024

Conversation

glennsong09
Copy link
Contributor

It seems to be an unintentional change, but the current behavior is not documented anywhere.

Addresses #1917.

@derobins
Copy link
Member

Documenting the change in behavior is great, but we shouldn't close the issue until we understand why the change occurred and whether we're happy with the current behavior.

@jhendersonHDF
Copy link
Collaborator

Documenting the change in behavior is great, but we shouldn't close the issue until we understand why the change occurred and whether we're happy with the current behavior.

Bisected to ca1b902

@glennsong09
Copy link
Contributor Author

Documenting the change in behavior is great, but we shouldn't close the issue until we understand why the change occurred and whether we're happy with the current behavior.

If I delete the line in my PR, does it stop it from automatically closing the issue?

@jhendersonHDF
Copy link
Collaborator

Documenting the change in behavior is great, but we shouldn't close the issue until we understand why the change occurred and whether we're happy with the current behavior.

If I delete the line in my PR, does it stop it from automatically closing the issue?

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

"Addresses" isn't one of GitHub's keywords, so this PR shouldn't close the issue when it's merged. You can also look in the Development section in the bottom right to see if the issue is linked to the PR.

mattjala
mattjala reviewed Mar 18, 2024
View reviewed changes
src/H5Gpublic.h Outdated
@@ -1198,6 +1198,12 @@ H5_DLL ssize_t H5Gget_objname_by_idx(hid_t loc_id, hsize_t idx, char *name, size
* the group. This parameter is described in more detail in the
* discussion of H5Gget_objname_by_idx().
*
* \note As of 1.12.0, H5Get_objtype_by_idx() returns the type of the object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: H5Get_objtype_by_idx -> H5Gget_objtype_by_idx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

mattjala
mattjala requested changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@mattjala mattjala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides the typo

@lrknox lrknox merged commit 02b5204 into HDFGroup:develop Mar 22, 2024
51 checks passed
qkoziol pushed a commit to qkoziol/hdf5 that referenced this pull request Mar 23, 2024
@glennsong09 @qkoziol
Add clarification for current behavior of H5Get_objtype_by_idx() (HDF…
a88ff80 
…Group#4120)
lrknox pushed a commit to lrknox/hdf5 that referenced this pull request Mar 25, 2024
@glennsong09 @lrknox
Add clarification for current behavior of H5Get_objtype_by_idx() (HDF…
4120adf 
…Group#4120)
lrknox added a commit that referenced this pull request Mar 25, 2024
@lrknox
Sync develop changes March 20 - March 25 to hdf5_1_14. (#4241)
3c86f0f 
* Call memset before stat calls (#4202)

The buffers passed to stat-like calls are only partially filled in by
the call, leaving ununitialized memory areas when the stat buffers are
created on the stack.

This change memsets the buffers to 0 before the stat calls, quieting
the -fsanitze=memory complaints.

* Remove unused CMake configuration checks (#4199)

* Update link to Chunking in HDF5 page (#4203)

* Fix H5Pset_efile_prefix documentation error (#4206)

Fixes GH issue #1759

* Suggested header footer for NEWSLETTER (#4204)

* Suggested header footer for NEWSLETTER

* Updates

* Add NEWSLETTER.txt to h5vers script

* Fix grammar in README.md release template (#4201)

* Add back snapshot names (#4198)

* Use tar.gz extension for ABI reports (#4205)

* Fix issue with Subfiling VFD and multiple opens of same file (#4194)

* Fix issue with Subfiling VFD and multiple opens of same file

* Update H5_subfile_fid_to_context to return error value instead of ID

* Add helper routine to initialize open file mapping

* Reverts AC_SYS_LARGEFILE change (#4213)

We previously replaced local macros with AC_SYS_LARGEFILE, which is
unfortunately buggy on some systems and does not correctly set the
necessary defines, despite successfully detecting them.

This restores the previous macro hacks to acsite.m4

* Propagate group creation properties to intermediate groups (#4139)

* Add clarification for current behavior of H5Get_objtype_by_idx() (#4120)

* Addressed Fortran  issues with promoted integers and reals via compilation flags (#4209)

* addressed issue wit promoted integers and reals

* added option to use mpi_f08

* Summarize the library version table (#4212)

Fixes GH-3773

* Fix URLs (#4210)

Also removed Copyright.html context because it's no longer valid.

* Fix 'make check-vfd' target for Autotools (#4211)

Changes Autotools testing to use HDF5_TEST_DRIVER environment
variable to avoid running tests that don't work well with several
VFDs

Restores old h5_get_vfd_fapl() testing function to setup a FAPL
with a particular VFD

Adds a macro for the default VFD name

* Revert "Addressed Fortran  issues with promoted integers and reals via compil…" (#4220)

This reverts commit 06c42ff.

* Backup and clear CMAKE_C_FLAGS before performing _Float16 configure checks (#4217)

* Fix broken links (#4224)

* Fix broken URLs in documentation (#4214)

Fixes GH-3881 partially.  There are pages that need to be recreated.

* Avoid file size checks in C++ testhdf5 for certain VFDs (#4226)

* Fix an issue with type size assumptions in h5dumpgentest (#4222)

* Fix issue with -Werror cleanup sed command in configure.ac (#4223)

* Fix Java JNI warnings (#4229)

* Rework snapshots/release workflows for consistent args (#4227)

* Fixed a cache assert with too-large metadata objects (#4231)

If the library tries to load a metadata object that is above the
library's hard-coded limits, the size will trip an assert in debug
builds. In HDF5 1.14.4, this can happen if you create a very large
number of links in an old-style group that uses local heaps.

The library will now emit a normal error when it tries to load a
metadata object that is too large.

Partially addresses GitHub #3762

* Set DXPL in API context for native VOL attribute I/O calls (#4228)

* Initialize a variable in C++ testhdf5's tattr.cpp (#4232)

* Addressed Fortran issues with promoted integers and reals via compilation flags, part 2 (#4221)

* addressed issue wit promoted integers and reals

* fixed h5fcreate_f

* added option to use mpi_f08

* change the kind of logical in the parallel tests

* addressed missing return value from callback

* Use cp -rp in test_plugin.sh (#4233)

When building with debug symbols on MacOS, the cp -p commands in
test_plugin.sh will attempt to copy the .dSYM directories with
debugging info, which will fail since -r is missing.

Using cp -rp is harmless and allows the test to run

Fixes HDFFV-10542

* Clean up types in h5test.c (#4235)

Reduces warnings on 32-bit and LLP64 systems

* Fix example links (#4237)

* Fix links md files (#4239)

* Add markdown link checker action (#4219)

* Match minimum CMake version to 3.18 (#4215)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendersonHDF jhendersonHDF jhendersonHDF approved these changes

@bmribler bmribler bmribler approved these changes

@mattjala mattjala mattjala approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@byrnHDF byrnHDF Awaiting requested review from byrnHDF byrnHDF is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees

@lrknox lrknox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@glennsong09 @derobins @jhendersonHDF @bmribler @mattjala @lrknox