Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Julia GitHub Actions. #4123

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

hyoklee
Copy link
Member

@hyoklee hyoklee commented Mar 12, 2024

These minimal Actions test the latest release version (1.6) of HDF5 Julia with HDF5 develop branch.

Both CMake and Autotools Actions fail as of 2024-03-12:

Test Summary:                      | Pass  Fail  Broken  Total
HDF5.jl                            | 1498     1       3   1502
  plain                            |  151             1    152

Action names follow this convention.

close #3857

@derobins derobins added Merge - To 1.14 Priority - 1. High 🔼 These are important issues that should be resolved in the next release Component - Testing Code in test or testpar directories, GitHub workflows Type - Improvement Improvements that don't add a new feature or functionality labels Mar 12, 2024
@derobins
Copy link
Member

Why does this pass if the interface has breakage?

@mkitti
Copy link
Contributor

mkitti commented Mar 14, 2024

properties: Test Failed at /home/runner/work/hdf5/hdf5/test/properties.jl:73
  Expression: fapl.libver_bounds == (:earliest, Base.thisminor(HDF5.libversion))
   Evaluated: (:earliest, v"1.14.0") == (:earliest, v"1.15.0")

@hyoklee
Copy link
Member Author

hyoklee commented Mar 15, 2024

Hi, @mkitti !

Thank you so much for checking failure and asking developers to check this CI.

Is there a quick way to disable the version test using julia-actions/julia-runtest@latest?

Also, how can I examine broken tests?

Regards,

@derobins
Copy link
Member

If this is a version problem, can it be merged to the 1.14 branch?

@mkitti
Copy link
Contributor

mkitti commented Mar 23, 2024

I plan on changing the test. I'll do this today.

@mkitti
Copy link
Contributor

mkitti commented Mar 23, 2024

Here we are testing if the default FAPL libver_bounds is earliest to latest.

The issue is we need to infer the value of H5F_LIBVER_LATEST and this test should use that value.

@mkitti
Copy link
Contributor

mkitti commented Mar 23, 2024

Also, how can I examine broken tests?

The broken tests are tests that are known to not work. If the tests actually do work, then the test system will report a failure suggesting that we should no longer mark the tests as broken.

@mkitti
Copy link
Contributor

mkitti commented Mar 26, 2024

This should work now after JuliaIO/HDF5.jl#1145. Please re-run the tests.

@jhendersonHDF
Copy link
Collaborator

This should work now after JuliaIO/HDF5.jl#1145. Please re-run the tests.

Seems like the Julia actions passed. Thanks @mkitti!

@mkitti
Copy link
Contributor

mkitti commented Mar 26, 2024

By the way, the latest stable release is Julia 1.10.2:
https://julialang.org/downloads/

Julia 1.6 is the latest Long Term Support (LTS) release.

@lrknox lrknox merged commit 967db7f into HDFGroup:develop Mar 27, 2024
51 checks passed
lrknox pushed a commit to lrknox/hdf5 that referenced this pull request Mar 29, 2024
lrknox added a commit that referenced this pull request Mar 29, 2024
* Take user block into account when returning chunk addresses (#4236)

Both H5Dchunk_iter() and H5Dget_chunk_info(_by_coord)() did not take
the size of the user block into account when reporting addresses. Since
the #1 use of these functions is to root around in the file for the raw
data, this is kind of a problem.

Fixes GitHub issue #3003

* Fix a minor warning in h5test.c (#4242)

* Turn on -Werror for Java in GitHub -Werror workflows (#4243)

* Update Windows CI to not install ninja (#4230)

* Rework Fortran macros to use the proper code. (#4240)

* Correct reference copy for 16 API (#4244)

* Determine MPI LOGICAL during build, used in tests. (#4246)

* Skip userblock test in chunk_info.c for multi-file VFDs (#4249)

* Match generators with real cmake -G output on Windows (#4252)

* Add Julia GitHub Actions. (#4123)

* Re-revert to using autoreconf in autogen.sh (#4253)

We previously tried removing the per-tool invocation of the Autotools
and instead simply invoked autoreconf (PR #1906). This was reverted
when it turned out that the NAG Fortran compiler had trouble with an
undecorated -shared linker flag.

It turns out that this is due to a bug in libtool 2.4.2 and earlier.
Since this version of libtool is over a decade old, we're un-reverting
the change. We've added a release note for anyone who has to build
from source on elderly platforms.

Fixes #1343

* Rewrite H5T__path_find_real for clarity (#4225)

* Move conversion path free logic to helper function

* Add tgz extensions on names (#4255)

* Remove an error check regarding large cache objects (#4254)

* Remove an error check regarding large cache objects

In PR#4231 an assert() call was converted to a normal HDF5 error
check. It turns out that the original assert() was added by a
developer as a way of being alerted that large cache objects
existed instead of as a guard against incorrect behavior, making
it unnecessary in either debug or release builds.

The error check has been removed.

* Update RELEASE.txt

* File format security issues (#4234)

* Add job timeout to cygwin workflow (#4260)

* Replace user-define with user-defined (#4261)

* Improve the CMake clang -fsanitize=memory flags (#4267)

-fsanitize=memory is almost useless without
using -fsanitize-memory-track-origins=2 and we shoud probably add
-fno-optimize-sibling-calls as well.

* Add documentation (H5M) (#4259)

* Add documentation (H5P) (#4262)

* MPI type correction (#4268)

* corrected type for MPI_*_f2c APIs

* fixed return type of callback

* reset compilation flags of logical test program

* Clean up test/cmpd_dtransform.c (#4270)

* Clean up test/cmpd_dtransform.c

* Fix uninitialized memory warning from sanitizers
* FAIL_STACK_ERROR --> TEST_ERROR
* Emit output
* Delete test file when done

* Fix typo

* H5Fdelete() --> remove()

* Fix uninitialized memory issues in packet table (#4271)

* replace deprecated CMAKE_COMPILER_IS_GNU** (#4272)

* Prevent stack overflows in H5E__push_stack (#4264)

* Minor fixes after merge of file format security fixes (#4263)

* Update H5_IS_BUFFER_OVERFLOW to account for 'size' of 0

* Invert a few checks to avoid function call

* CHECK --> CHECK_PTR in tmisc.c (#4274)

* Add release note for CVE-2017-17507 (#4275)

* Update Cygwin installation guide (#4265)

* Addresses configuration fortran testing flags (#4276)

* turn warnings to errors in fortran configure test

* Intel fortran test fix

* Merge julia workflows into standard ci format (#4273)

* Fix range check in H5_addr_overlap (#4278)

When the H5_addr_overlap macro was updated to use H5_RANGE_OVERLAP,
it failed to take into account that H5_RANGE_OVERLAP expects the
range to be inclusive. This lead to an assertion failure in
H5MM_memcpy due to a memcpy operation on overlapping memory.
This has been fixed by subtracting 1 from the calculated high
bound values passed to H5_RANGE_OVERLAP

* Fix potential buffer read overflows in H5PB_read (#4279)

H5PB_read previously did not account for the fact that the size of the
read it's performing could overflow the page buffer pointer, depending
on the calculated offset for the read. This has been fixed by adjusting
the size of the read if it's determined that it would overflow the page.
@hyoklee hyoklee deleted the HDFGroup-hdf5-3857 branch April 1, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Testing Code in test or testpar directories, GitHub workflows Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
Status: Needs Merged
Development

Successfully merging this pull request may close these issues.

Add CI testing for HDF5/Julia
7 participants