Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NVHPC to 24.5 #4171

Merged
merged 3 commits into from
Jun 15, 2024
Merged

Update NVHPC to 24.5 #4171

merged 3 commits into from
Jun 15, 2024

Conversation

hyoklee
Copy link
Member

@hyoklee hyoklee commented Mar 18, 2024

This PR will reveal 2 test failures:

The following tests FAILED:
	 23 - H5TEST-dt_arith (Failed)
	 58 - H5TEST-dtransform (Failed)

dt_arith:

Testing hard signed char -> long double conversions
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7c3cdd6 in H5T__conv_schar_ldouble () from /home/hyoklee/hdf5/nv/bin/libhdf5.so.1000
(gdb) where
#0  0x00007ffff7c3cdd6 in H5T__conv_schar_ldouble () from /home/hyoklee/hdf5/nv/bin/libhdf5.so.1000
#1  0x00007ffff7bd791b in H5T_convert_with_ctx () from /home/hyoklee/hdf5/nv/bin/libhdf5.so.1000
#2  0x00007ffff7bd75e6 in H5T_convert () from /home/hyoklee/hdf5/nv/bin/libhdf5.so.1000
#3  0x00007ffff7bcff2d in H5Tconvert () from /home/hyoklee/hdf5/nv/bin/libhdf5.so.1000
#4  0x0000000000417bb3 in ?? ()
#5  0x0000000000407677 in ?? ()
#6  0x00000000004038ae in ?? ()
#7  0x00007ffff4e00d90 in __libc_start_call_main (main=main@entry=0x403800, argc=argc@entry=1, argv=argv@entry=0x7fffffffe088)
    at ../sysdeps/nptl/libc_start_call_main.h:58
#8  0x00007ffff4e00e40 in __libc_start_main_impl (main=0x403800, argc=1, argv=0x7fffffffe088, init=<optimized out>,
    fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffe078) at ../csu/libc-start.c:392
#9  0x0000000000403525 in ?? ()

dtransform:

Testing contiguous, with type conversion (float->double)               PASSED

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7c35bb4 in H5T__conv_float_ldouble () from /home/hyoklee/hdf5/nv/bin/libhdf5.so.1000
(gdb) where
#0  0x00007ffff7c35bb4 in H5T__conv_float_ldouble () from /home/hyoklee/hdf5/nv/bin/libhdf5.so.1000
#1  0x00007ffff7bd791b in H5T_convert_with_ctx () from /home/hyoklee/hdf5/nv/bin/libhdf5.so.1000
#2  0x00007ffff7bd75e6 in H5T_convert () from /home/hyoklee/hdf5/nv/bin/libhdf5.so.1000
#3  0x00007ffff788970d in H5D__scatgath_write () from /home/hyoklee/hdf5/nv/bin/libhdf5.so.1000
#4  0x00007ffff7840366 in H5D__contig_write () from /home/hyoklee/hdf5/nv/bin/libhdf5.so.1000
#5  0x00007ffff786bc26 in H5D__write () from /home/hyoklee/hdf5/nv/bin/libhdf5.so.1000
#6  0x00007ffff7cdaf6c in H5VL__native_dataset_write () from /home/hyoklee/hdf5/nv/bin/libhdf5.so.1000
#7  0x00007ffff7cc209b in ?? () from /home/hyoklee/hdf5/nv/bin/libhdf5.so.1000
#8  0x00007ffff7cae093 in H5VL_dataset_write_direct () from /home/hyoklee/hdf5/nv/bin/libhdf5.so.1000
#9  0x00007ffff780f7aa in ?? () from /home/hyoklee/hdf5/nv/bin/libhdf5.so.1000
#10 0x00007ffff7808f8d in H5Dwrite () from /home/hyoklee/hdf5/nv/bin/libhdf5.so.1000
#11 0x00000000004087d7 in ?? ()
#12 0x00007ffff5200d90 in __libc_start_call_main (main=main@entry=0x4023c0, argc=argc@entry=1, argv=argv@entry=0x7fffffffe078)
    at ../sysdeps/nptl/libc_start_call_main.h:58
#13 0x00007ffff5200e40 in __libc_start_main_impl (main=0x4023c0, argc=1, argv=0x7fffffffe078, init=<optimized out>,
    fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffe068) at ../csu/libc-start.c:392
#14 0x00000000004022a5 in ?? ()

@hyoklee hyoklee changed the title Update NVHPC to 24.3. Update NVHPC to 24.5 Jun 3, 2024
@hyoklee hyoklee added Component - C Library Core C library issues (usually in the src directory) Component - Testing Code in test or testpar directories, GitHub workflows labels Jun 10, 2024
We don't test parallel in other GitHub actions, so this converts the
NVHPC check to configure and build only while we discuss how we'll
test parallel HDF5 in GitHub.

There is a blocking GitHub issue to address the test failures for
HDF5 1.14.5 (HDFGroup#4571).
@derobins derobins added Merge - To 1.14 Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality and removed Component - C Library Core C library issues (usually in the src directory) labels Jun 15, 2024
@derobins derobins marked this pull request as ready for review June 15, 2024 05:14
@derobins derobins merged commit 3ab0832 into HDFGroup:develop Jun 15, 2024
56 checks passed
byrnHDF pushed a commit to byrnHDF/hdf5 that referenced this pull request Jun 26, 2024
We don't test parallel in other GitHub actions, so this also converts the
NVHPC check to configure and build only while we discuss how we'll
test parallel HDF5 in GitHub.

There is a blocking GitHub issue to address the test failures for
HDF5 1.14.5 (HDFGroup#4571).
lrknox pushed a commit to lrknox/hdf5 that referenced this pull request Jul 2, 2024
We don't test parallel in other GitHub actions, so this also converts the
NVHPC check to configure and build only while we discuss how we'll
test parallel HDF5 in GitHub.

There is a blocking GitHub issue to address the test failures for
HDF5 1.14.5 (HDFGroup#4571).
lrknox added a commit that referenced this pull request Jul 3, 2024
* Fix typos in context/property documentation (#4550)

* Fix CI markdown link check http 500 errors (#4556)

Sites like GitLab can have internal problems that return http 500
errors while they fix their problems. Some sites also return http
200 OK, which is fine.

This PR adds a config file to the markdown link check so those
are considered "passing" and don't break the CI.

* Simplify property copying between lists internally (#4551)

* Add Python examples (#4546)

These examples are referred to from the replacement page of https://portal.hdfgroup.org/display/HDF5/Other+Examples.

* Correct property cb signatures in docs (#4554)

* Correct property cb signatures in docs
* Correct delete callback type name in docs
* add missing word to H5P__free_prop doc

* Move C++ and Fortran and examples to HDF5Examples folder (#4552)

* Document 'return-and-read' field in API context (#4560)

* Add compression includes to tests needing zlib support (#4561)

* Allow usage of page buffering for serial file access from parallel HDF5 builds (#4568)

* Remove old version of libaec (#4567)

* Add property names to context field docs (#4563)

* Document property shared name behavior (#4565)

* Clarify H5CX macro documentation (#4569)

* Document H5Punregister modifying default properties (#4570)

* Update NVHPC to 24.5 (#4171)

We don't test parallel in other GitHub actions, so this also converts the
NVHPC check to configure and build only while we discuss how we'll
test parallel HDF5 in GitHub.

There is a blocking GitHub issue to address the test failures for
HDF5 1.14.5 (#4571).

* Clean up comments in H5FDros3.c (#4572)

* Rename INSTALL_Auto.txt to INSTALL_Autotools.txt (#4575)

* Clean up ros3 VFD stats code (#4579)

* Removes printf debugging
* Simplifies and centralizes stats code
* Use #ifdef ROS3_STATS instead of #if
* Other misc tidying

* Turn off ros3 VFD stat collection by default (#4581)

Not a new change - an artifact from a previous check-in.

* Pause recording errors instead of clearing the error stack (#4475)

An internal capability that's similar to the H5E_BEGIN_TRY / H5E_END_TRY
macros in H5Epublic.h, but more efficient since we can avoid pushing errors on
the stack entirely (and those macros use public API routines).

This capability (and other techniques) can be used to remove use of
H5E_clear_stack() and H5E_BEGIN_TRY / H5E_END_TRY within library routines.

We want to remove H5E_clear_stack() because it can trigger calls to the H5I
interface from within the H5E code, which creates a great deal of complexity
for threadsafe code.  And we want to remove H5E_BEGIN_TRY / H5E_END_TRY's
because they make public API calls from within the library code.

Also some other minor tidying in routines related to removing the use of
H5E_clear_stack() and H5E_BEGIN_TRY / H5E_END_TRY from H5Fint.c

* Add page buffer cache command line option to tools (#4562)


Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

* Clarify documentation for H5CX_get_data_transform (#4580)

* Correct comment for H5CX_get_data_transform

* Document why data transform ctx field doesnt use macro

* Remove public API call from ros3 VFD (#4583)

* Remove printf debugging from H5FDs3comms.c (#4584)

* Cleanup of ros3 test (#4587)

* Removed JS* macro scheme (replaced w/ h5test.h macros)
* Moved curl setup/teardown to main()
* A lot of cleanup and simplification

* Removed unused code from H5FDs3comms.c (#4588)

* H5FD_s3comms_nlowercase()
* H5FD_s3comms_trim()
* H5FD_s3comms_uriencode()

* Remove magic fields from s3comms structs (#4589)

* Remove dead H5FD_s3comms_percent_encode_char() (#4591)

* Rework the TestExpress usage and refactor dead code (#4590)

* Skip examples if running sanitizers (#4592)

* Clean up s3comms test code (#4594)

* Remove JS* macros
* Remove dead code
* Bring in line with other test code

* Add publish to bucket workflow (#4566)

* Update abi report CI workflow for last release (#4596)

* Update abi report workflow to handle 1.14.4.3 release

* Update name of java report

* Document that ctx VOL property isn't drawn from the FAPL (#4597)

* Update macos workflow to 14 (keep 13 as alternate) (#4603)

* Removed unnecessary call to H5E_clear_stack (#4607)

H5FO_opened and H5SL_search don't push errors on the stack

* Bring subfiling VFD code closer to typical library code (#4595)

Remove API calls, use FUNC_ENTER/LEAVE macros, use the library's error macros,
rename functions to have more standardized names, etc.

* Correct documentation for return-and-read fields (#4598)

* These two generators create strings without NUL for testing (#4608)

* Fix Fortran pkconfig to indicate full path of modules (#4593)

* Updated release schedule (#4615)

1.16 and 2.0 information

* Document VOL object wrapping context (#4611)

* Earray.c and farray.c in hdf5_1_14 still need time_t curr_time for HDsrandom.

* Remove line to use future 116_API from CMakeListat.txt files in HDF5
examples directories
@hyoklee hyoklee deleted the hyoklee-hdf5-162 branch August 24, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Testing Code in test or testpar directories, GitHub workflows Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
Status: Needs Merged
Development

Successfully merging this pull request may close these issues.

2 participants