Fix fatal error C1083: Cannot open include file #4250
Conversation
hyoklee
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
| @@ -23,7 +23,7 @@ | |||
| #define H5_ZLIB_HEADER "zlib.h" | |||
| #endif | |||
| #if defined(H5_ZLIB_HEADER) | |||
| #include H5_ZLIB_HEADER /* "zlib.h" */ | |||
| #include H5_ZLIB_HEADER "zlib.h" | |||
There was a problem hiding this comment.
I don't think you want both, and why does H5_ZLIB_HEADER fail since it should be exactly the same as the text you added?
There was a problem hiding this comment.
direct_chunk.c has the same include block - does it fail?
There was a problem hiding this comment.
The reason it is not hard-coded is that the header file could be overridden with something different.
There was a problem hiding this comment.
direct_chunk.c has the same include block - does it fail?
No. (I guess build process failed before it reached direct_chunk.c).
There was a problem hiding this comment.
I don't think you want both, and why does H5_ZLIB_HEADER fail since it should be exactly the same as the text you added?
I think the problem is escape character: \"zlib.h\". How can we fix it?
There was a problem hiding this comment.
That was passed in as a define so that needs fixed
|
@byrnHDF, I set |
|
By the way, why is it called
|
See https://cdash.hdfgroup.org/viewBuildError.php?buildid=125323