Sync develop changes 9/11 - 9/13 to hdf5_1_14 #4833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where the vector I/O sizes weren't being extended when one of the entries in the array is 0. This caused an over-read of the I/O sizes buffer and on some machines would cause a memory allocation failure due to the calculated I/O vector size being too large.
lrknox
requested review from
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
byrnHDF
reviewed
Sep 13, 2024
config/cmake/FindHDFS.cmake
Outdated
| @@ -8,7 +8,7 @@ | |||
| # HDFS_FOUND, whether HDFS is found. | |||
|
|
|||
| execute_process(COMMAND $ENV{HADOOP_HOME}/bin/hadoop version OUTPUT_VARIABLE Hadoop_VERSION | |||
| RESULT_VARIABLE Hadoop_RETURN) | |||
| RESULT_VARIABLE_VALUE Hadoop_RETURN) | |||
There was a problem hiding this comment.
Should not be changed - "VALUE" is incorrect
byrnHDF
approved these changes
Sep 13, 2024
lrknox
added
Branch - 1.14
Priority - 0. Blocker ⛔
derobins
reviewed
Sep 13, 2024
release_docs/RELEASE.txt
Outdated
| multiple threads. It is possible to enable the 'threads' option and | ||
| disable the 'threadsafe' option, but not vice versa. The 'threads' option | ||
| must be on to enable the subfiling VFD. | ||
|
|
There was a problem hiding this comment.
This should not have been merged to 1.14. --enable-threads and HDF5_ENABLE_THREADS should be develop-only.
derobins
requested changes
Sep 13, 2024
not for HDF5 1.14.5.
Release note about --enable-threads has been removed. |
byrnHDF
approved these changes
Sep 16, 2024
derobins
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.