Remove the hash_size param from H5Iregister_type() #5170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 2, 2024 08:41
* Add the function call (copy of existing H5Iregister_type) * Add H5Ideprec.c * Remove the hash_size parameter from H5Iregister_type * Copy the basic test in tid.c and use the register1 call instead * No make_vers changes at this time
* Update bin/make_vers to handle v200 * H5Iregister_type() --> H5Iregister_type2() The bin/make_vers script could still use some cleanup regarding the hash table / index magic, which seems over-complicated. Also, H5Iregister_type1/2 should have common code extracted.
Replaces the overly complicated file parse with something a LOT simpler.
derobins
added
Priority - 2. Medium ⏹
derobins
requested review from
jhendersonHDF,
byrnHDF,
lrknox,
fortnern,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
derobins
commented
Dec 8, 2024
| } else { | ||
| die "unknown line type: $line"; | ||
| $api_vers_to_type_vers{$hash_vers}{$name} = $curr_sym_number; |
There was a problem hiding this comment.
All that index manipulation nonsense reduced to about a dozen lines of code that even handles the v111 complication without additional logic.
derobins
commented
Dec 8, 2024
There was a problem hiding this comment.
I reworked the whole script to just use an explicit list of supported versions. All that array index complexity was giving me a headache.
mattjala
approved these changes
Dec 9, 2024
| *------------------------------------------------------------------------- | ||
| */ | ||
| H5I_type_t | ||
| H5I__register_type_common(unsigned reserved, H5I_free_t free_func) |
There was a problem hiding this comment.
Seems like this function should return a pointer to the registered class rather than H5I_type_t so that if an error occurs later the code can free the registered class if need be.
qkoziol
approved these changes
Dec 10, 2024
|
I'm going to go ahead and merge this to get the make_vers changes in. I'll address Jordan's comment in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hash_size parameter of H5Iregister_type() hasn't been used since 1.8.
It's been removed and the API call has been versioned.
This PR also updates the make_vers script to handle v2.0.0.
Fixes #4344