Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves H5PacketTable default ctor inside source file #731

Merged
merged 1 commit into from
Jun 6, 2021
Merged

Moves H5PacketTable default ctor inside source file #731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/commence.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ LIBH5CPP_HL=$(top_builddir)/hl/c++/src/libhdf5_hl_cpp.la
docdir = $(exec_prefix)/doc

# Note that in svn revision 19400 the '/' after DESTDIR in H5* variables below
# has been removed. According to the official description of DESTDIR by Gnu at
# has been removed. According to the official description of DESTDIR by GNU at
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo I noticed...

# http://www.gnu.org/prep/standards/html_node/DESTDIR.html, DESTDIR is
# prepended to the normal and complete install path that it precedes for the
# purpose of installing in a temporary directory which is useful for building
Expand Down
7 changes: 7 additions & 0 deletions hl/c++/src/H5PacketTable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@
/* PacketTable superclass */
/********************************/

/* Null constructor
* Sets table_id to "invalid"
*/
PacketTable::PacketTable() : table_id{H5I_INVALID_HID}
{
}

/* "Open" Constructor
* Opens an existing packet table, which can contain either fixed-length or
* variable-length packets.
Expand Down
6 changes: 2 additions & 4 deletions hl/c++/src/H5PacketTable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,9 @@
class H5_HLCPPDLL PacketTable {
public:
/* Null constructor
* Sets table_id to "invalid"
* Sets table_id to H5I_INVALID_HID
*/
PacketTable() : table_id{H5I_INVALID_HID}
{
}
PacketTable();

/* "Open" Constructor
* Opens an existing packet table, which can contain either fixed-length or
Expand Down