Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map design doc #399

Merged
merged 4 commits into from
Oct 8, 2024
Merged

map design doc #399

merged 4 commits into from
Oct 8, 2024

Conversation

jreadey
Copy link
Member

@jreadey jreadey commented Oct 7, 2024

Deisgn docs for Map support

Copy link
Contributor

@mattjala mattjala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll discuss the design later, but the document can go in

@mattjala mattjala merged commit aa038a0 into master Oct 8, 2024
38 checks passed
@mattjala mattjala deleted the mapdesign branch October 8, 2024 16:13
None

Returns:
Value for gieven key as JSON or binary blob. Or 404 if not found
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gieven -> given


* verbose: provide additional information in the respose

Returns: JSON describing map object. If verbose is set, additional daa will be returned (e.g. number oF KV pairs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oF -> of


### Delete a key

This request removes a given key an its associatted value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an its -> and its
associatted -> associated

Copy link
Member

@hyoklee hyoklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattjala & @jreadey , please fix typos

@jreadey
Copy link
Member Author

jreadey commented Oct 9, 2024

fixed typos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants