Removed source code associated with variants of HDF5 1.13 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brtnfld
changed the title
brtnfld
commented
Nov 14, 2024
| @@ -8878,21 +8842,68 @@ async_dataset_read_merge_mdset_col(async_instance_t *aid, size_t count, H5VL_asy | |||
|
|
|||
| done: | |||
| return found_task; | |||
| } // End async_dataset_read_merge_mdset_col > 1.13.3 | |||
| } // End async_dataset_read_merge_mdset_col | |||
There was a problem hiding this comment.
This is not getting displayed correctly in terms of the diff.
There was a problem hiding this comment.
To get the changes' renderings correct, you will need to use a tool like Meld for the git diff.
jhendersonHDF
approved these changes
Nov 18, 2024
houjun
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum requirement is HDF5 1.14, so the code is no longer needed.