Test opening dataset with fill value (#63)

* Test opening dataset with fill value in DCPL
HDFGroup · Jan 10, 2024 · ded363b · ded363b
1 parent 53722ba
commit ded363b
Showing 1 changed file with 41 additions and 2 deletions.
diff --git a/vol_dataset_test.c b/vol_dataset_test.c
@@ -2488,6 +2488,19 @@ test_create_dataset_creation_properties(void)
                 PART_ERROR(DCPL_fill_value_test);
             }
 
+            /* Re-open integer dataset */
+            if ((dset_id = H5Dopen2(group_id, DATASET_FILL_VALUE_TEST_DSET_NAME1, H5P_DEFAULT)) < 0) {
+                H5_FAILED();
+                HDprintf("    couldn't open integer fill value dataset");
+                PART_ERROR(DCPL_fill_value_test);
+            }
+
+            if (H5Dclose(dset_id) < 0) {
+                H5_FAILED();
+                HDprintf("    couldn't close opened integer fill value dataset");
+                PART_ERROR(DCPL_fill_value_test);
+            }
+
             HDfree(read_buf);
             read_buf = NULL;
 
@@ -2549,6 +2562,19 @@ test_create_dataset_creation_properties(void)
                 PART_ERROR(DCPL_fill_value_test);
             }
 
+            /* Re-open double dataset */
+            if ((dset_id = H5Dopen2(group_id, DATASET_FILL_VALUE_TEST_DSET_NAME2, H5P_DEFAULT)) < 0) {
+                H5_FAILED();
+                HDprintf("    couldn't open double fill value dataset");
+                PART_ERROR(DCPL_fill_value_test);
+            }
+
+            if (H5Dclose(dset_id) < 0) {
+                H5_FAILED();
+                HDprintf("    couldn't close opened double fill value dataset");
+                PART_ERROR(DCPL_fill_value_test);
+            }
+
             HDfree(read_buf);
             read_buf = NULL;
 
@@ -2606,14 +2632,14 @@ test_create_dataset_creation_properties(void)
 
                 if (strcmp(val_str, DATASET_FILL_VALUE_TEST_STRING_FILL_VALUE)) {
                     H5_FAILED();
-                    HDprintf("    incorrect value read fromstring  dataset");
+                    HDprintf("    incorrect value read from string  dataset");
                     PART_ERROR(DCPL_fill_value_test);
                 }
             }
 
             if (H5Dclose(dset_id) < 0) {
                 H5_FAILED();
-                HDprintf("    couldn't close double fill value dataset");
+                HDprintf("    couldn't close string fill value dataset");
                 PART_ERROR(DCPL_fill_value_test);
             }
 
@@ -2632,6 +2658,19 @@ test_create_dataset_creation_properties(void)
             HDfree(read_buf);
             read_buf = NULL;
 
+            /* Re-open string dataset */
+            if ((dset_id = H5Dopen2(group_id, DATASET_FILL_VALUE_TEST_DSET_NAME3, H5P_DEFAULT)) < 0) {
+                H5_FAILED();
+                HDprintf("    couldn't open string fill value dataset");
+                PART_ERROR(DCPL_fill_value_test);
+            }
+
+            if (H5Dclose(dset_id) < 0) {
+                H5_FAILED();
+                HDprintf("    couldn't close opened string fill value dataset");
+                PART_ERROR(DCPL_fill_value_test);
+            }
+
             PASSED();
         }
         PART_END(DCPL_fill_value_test);