Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Fix) Invalid value type for page in Torrent search #4273

Merged
merged 1 commit into from
Oct 23, 2024
Merged

(Fix) Invalid value type for page in Torrent search #4273

merged 1 commit into from
Oct 23, 2024

Conversation

HDVinnie
Copy link
Collaborator

  • This ensures that the page parameter is correctly cast to an integer before being passed to the Meilisearch API.

@HDVinnie
fix: Invalid value type at page, expected a positive integer, but fou…
161031c 
…nd a string

- This ensures that the page parameter is correctly cast to an integer before being passed to the Meilisearch API.
@HDVinnie HDVinnie requested a review from Roardom October 23, 2024 04:52
Roardom
Roardom reviewed Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@Roardom Roardom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need to be casted to 1 and not 0. Have you tested it yet? (I haven't)

@HDVinnie HDVinnie merged commit 47cd932 into 8.x.x Oct 23, 2024
10 checks passed
@HDVinnie HDVinnie deleted the meilisearch-pagination branch October 23, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roardom Roardom Roardom left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HDVinnie @Roardom