Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Waline is broken after updating the client to V3 #1205

Closed
CXwudi opened this issue Mar 14, 2024 · 3 comments
Closed

[BUG] Waline is broken after updating the client to V3 #1205

CXwudi opened this issue Mar 14, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@CXwudi
Copy link
Contributor

CXwudi commented Mar 14, 2024

Describe the bug 描述你遇到的错误

As the title suggested, the waline is broken after 3964265

Expected behavior 期待的行为

The waline should show up even with V3

Screenshots 屏幕截图

image
image

Build Environment 构建环境

  • OS: Debian 12 from devcontainer
  • Theme: 982b081
  • Hugo: v0.121.2 Extend

Preview Environment 预览环境

  • OS: Windows 10 Pro
  • Browser: Brave Version 1.61.104 Chromium: 120.0.6099.115

Additional Information 补充信息

I revert back to the commit before 3964265 which uses the V2 version of the waline, and it works well
@CXwudi CXwudi added the bug Something isn't working label Mar 14, 2024
@CXwudi
Copy link
Contributor Author

CXwudi commented Mar 14, 2024

I am not sure if this is also related walinejs/waline#2379, maybe it is Waline's side problem?

@HEIGE-PCloud
Copy link
Owner

I think it's related to this one

walinejs/waline#2204

I will have to revert back to v2 for now.

@CXwudi
Copy link
Contributor Author

CXwudi commented Mar 14, 2024

I see, I'm wondering why would the ES module thing break the blog

@CXwudi CXwudi mentioned this issue Apr 26, 2024
Closed
hodory pushed a commit to hodory/DoIt that referenced this issue Dec 16, 2024
@HEIGE-PCloud @hodory
fix(comment): revert Waline back to v2
0561a1c 
Fix HEIGE-PCloud#1205
See walinejs/waline#2204
Jatin794 pushed a commit to Jatin794/bog that referenced this issue Dec 19, 2024
@HEIGE-PCloud @Jatin794
fix(comment): revert Waline back to v2
350a3e0 
Fix HEIGE-PCloud#1205
See walinejs/waline#2204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CXwudi @HEIGE-PCloud