Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace structlog with logging #114

Closed
wants to merge 3 commits into from
Closed

Replace structlog with logging #114

wants to merge 3 commits into from

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Jan 12, 2021

to close #113

@dimaqq dimaqq requested a review from ojii January 12, 2021 02:02
dimaqq
dimaqq commented Jan 12, 2021
View reviewed changes
src/arsenic/connection.py Outdated Show resolved Hide resolved
@dimaqq
Copy link
Contributor Author

dimaqq commented Jan 28, 2021

@ojii ping?

@ojii
Copy link
Contributor

ojii commented Jan 28, 2021

@ojii ping?

Personally I really dislike stdlib logging. I find it's interface ridiculous. For my needs structlog always "just works" which I appreciate. but I feel this is a discussion I won't win, so I guess this is "fine"...

Do tests still output logs by default? That was a useful feature of structlog to debug issues.

@dimaqq dimaqq closed this Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojii ojii Awaiting requested review from ojii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove structlog
2 participants
@dimaqq @ojii