Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kerberos auth support in security config #88

Merged
merged 5 commits into from
Apr 23, 2018

Conversation

ccnifo
Copy link
Collaborator

@ccnifo ccnifo commented Feb 15, 2018

This PR aims at integrating config parameters for kerberos auth.
It splits into:

  • replacing the ineffective (missing) krb_map_file_source with a template. For now, enabling krb_map_file just produces an error.
  • adding to security config the kerberos related params.

Some keywords (I think of "Optional") should break Puppet 3 compatibility; it's not an officially supported Puppet version now, but if for some reason compatbility is required, I should be able to change it. But I have no Puppet 3 test platform to ensure compatibility.

This PR should probably come with some documentation, could you please point me out where I should put it?

Thanks,

@ccnifo
Copy link
Collaborator Author

ccnifo commented Apr 16, 2018

No activity on this repo since 2+ months, is there a problem?

@kreczko
Copy link
Member

kreczko commented Apr 16, 2018

Apologies, this indeed fell under the radar.

The travis-ci checks are still failing, but only for Puppet 3:

Could not parse for environment *root*: Syntax error at 'Optional'; expected ')' at /home/travis/build/HEP-Puppet/htcondor/manifests/config/security.pp:2

I assume 'Optional' is not in Puppet 3's vocabulary.

While I am all in favour to switch to Puppet >= 4 only, some sites are still relying on Puppet 3 compatibility.

@ccnifo
Copy link
Collaborator Author

ccnifo commented Apr 18, 2018

OK; Puppet 3 is gone for more than 1 year but that's only a small change, so here it is!
EDIT: These new params miss some documentation entries: where would you write it?

@kreczko
Copy link
Member

kreczko commented Apr 19, 2018

Thanks, this looks good now.
For documentation, we recently started to add special cases (e.g. singularity) to the README.
Feel free to do the same.

Do you want me to merge & you make another PR for documentation or shall I wait?

@ccnifo ccnifo force-pushed the kerberos_parameters branch from a5e4972 to 450777c Compare April 20, 2018 12:41
@ccnifo
Copy link
Collaborator Author

ccnifo commented Apr 20, 2018

OK, I added some entries in the README, thanks.

@kreczko
Copy link
Member

kreczko commented Apr 23, 2018

@ccnifo Thank you very much for the contribution and changes.
Yes, Puppet 3 is gone, maybe my memory is a bit deprecated on this.
I think I will ask tomorrow at the OPS meeting if anyone is still using it. If not, I will replace the Puppet 3 tests with Puppet 5.

@kreczko kreczko merged commit ca811b0 into HEP-Puppet:master Apr 23, 2018
@ccnifo ccnifo deleted the kerberos_parameters branch April 25, 2018 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants