Fixing invalid SINGULARITY_IMAGE_EXPR by adding missing double-quotes

[kreczko]

SINGULARITY_IMAGE_EXPR needs to be within double-quotes for HTCondor to parse it correctly

The current implementation causes the following error with condor 8.6.11:

05/31/18 16:20:14 (pid:100974) Singularity support was requested but unable to determine the image to use.
05/31/18 16:20:14 (pid:100974) Singularity enabled but setup failed; failing job.
05/31/18 16:20:14 (pid:100974) Failed to start job, exiting
05/31/18 16:20:14 (pid:100974) ShutdownFast all jobs.

[olifre]

Doesn't this depend on the usecase?
We have

singularity_image_expr  =>   '$(CHOSEN_IMAGE)'

in our puppet code, which created the following config before this commit:

SINGULARITY_IMAGE_EXPR = $(CHOSEN_IMAGE)

Elsewhere in our condor-config, we define:

SL6_DEFAULT_IMAGE = /somewhere/SL6
UBUNTU1604_DEFAULT_IMAGE = /somewhere/Ubuntu1604
CHOSEN_IMAGE = "$(SL6_DEFAULT_IMAGE)"
CHOSEN_IMAGE = ifThenElse(TARGET.ContainerOS is "Ubuntu1604", "$(UBUNTU1604_DEFAULT_IMAGE)", $(CHOSEN_IMAGE))

Forcefully adding double quotes in the puppet template makes the expression as such unusable.

It's now only possible to ever define a single image using this puppet module, which is a severe loss of functionality.

[olifre]

I've put this up as issue #91 .