Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: custom params #95

Merged
merged 3 commits into from
Jul 17, 2018
Merged

Conversation

ccnifo
Copy link
Collaborator

@ccnifo ccnifo commented Jul 17, 2018

This PR fixes GH-57 by adding a hash which can take any parameter/value pair.
I added a typo fix that do not deserve a dedicated PR.

@kreczko
Copy link
Member

kreczko commented Jul 17, 2018

This turned out quite nicely! Thanks!

I will merge and make a new release

@kreczko kreczko merged commit 7672631 into HEP-Puppet:master Jul 17, 2018
@ccnifo ccnifo deleted the feature/custom_params branch July 17, 2018 12:55
@kreczko
Copy link
Member

kreczko commented Jul 17, 2018

Two new releases:

  • version 2.0.9: new patch release; master branch before merge
  • version 2.1.0: new minor release including this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add general knob turning
2 participants