Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oldhepdata: remove default None values for the data_license in submission.yaml #32

Closed
GraemeWatt opened this issue Mar 19, 2020 · 0 comments

Comments

@GraemeWatt
Copy link
Member

Remove these lines:

'data_license': {
'name': None,
'url': None,
'description': None # (optional)
},

since None is not a valid value of these fields in version 1.0.0 of the schema, where a string is expected. This problem has been worked around in the code for the main web app (HEPData/hepdata) by temporarily validating using version 0.1.0 of the schema if uploading an oldhepdata file, where no checks at all were made on the data_license. The temporary fix to validate using version 0.1.0 of the schema should be removed after this issue is closed and a new hepdata-converter version is made available.

GraemeWatt added a commit to HEPData/hepdata that referenced this issue Mar 19, 2020
* Upgrade to latest hepdata-converter-ws-client v0.1.4.
* Pass validator_schema_version='0.1.0' converter option (closes #188).
* Also validate using old schema if converting from oldhepdata format.
* Remove this temporary fix after HEPData/hepdata-converter#32 closed.

Signed-off-by: Graeme Watt <Graeme.Watt@durham.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant