Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add SERVER_NAME to configuration for GitHub Actions #723

Closed
GraemeWatt opened this issue Nov 1, 2023 · 0 comments · Fixed by #724
Closed

ci: add SERVER_NAME to configuration for GitHub Actions #723

GraemeWatt opened this issue Nov 1, 2023 · 0 comments · Fixed by #724
Assignees
@GraemeWatt
Labels
complexity: low priority: critical type: bug Indicates an unexpected problem or unintended behaviour

Comments

@GraemeWatt
Copy link
Member

The last successful nightly CI run was on 23 October 2023 and it has been failing since 24 October 2023, coinciding with the release of pytest-flask 1.3.0 which introduced a breaking change if SERVER_NAME is not given in the configuration. The workaround (pytest-dev/pytest-flask#175) is to explicitly set SERVER_NAME = 'localhost' to recover the previous behaviour.
@GraemeWatt GraemeWatt added type: bug Indicates an unexpected problem or unintended behaviour priority: critical complexity: low labels Nov 1, 2023
@GraemeWatt GraemeWatt self-assigned this Nov 1, 2023
@github-project-automation github-project-automation bot moved this to To do in @HEPData Nov 1, 2023
@GraemeWatt GraemeWatt mentioned this issue Nov 1, 2023
Merged
@github-project-automation github-project-automation bot moved this from To do to Done in @HEPData Nov 1, 2023
GraemeWatt added a commit that referenced this issue Dec 14, 2023
@GraemeWatt
config: use SERVER_NAME = "localhost" for local
b33e61a 
* Same issue running tests locally as for GitHub Actions in #723.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GraemeWatt GraemeWatt

Labels
complexity: low priority: critical type: bug Indicates an unexpected problem or unintended behaviour
Projects
@HEPData
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add SERVER_NAME to configuration for GitHub Actions HEPData/hepdata
1 participant
@GraemeWatt