-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation of output tarballs #189
Conversation
I also added a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of hidden gems in this PR ;-)
I forgot, shall we remove Python2 support with this PR? That would mean removing it from https://github.com/HEPData/hepdata_lib/blob/master/setup.py#L30 |
Removed python2 from setup.py now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, and there goes Python2!
With this PR,
Submission.create_files
now automatically calls the hepdata validator on the output file. An AssertionError is thrown if the tar ball is found to be invalid.Closes #160