ci: Use micromamba to test Python and ROOT #220

matthewfeickert · 2023-02-22T07:25:35Z

Resolves Test all supported Python versions #200.
Closes WIP: revive macOS CI #171

Requires #218 to go in first.

Use the mamba-org/provision-with-micromamba GitHub action to setup a micromamba enviroment with a ROOT version and CPython version defined by the CI matrix.
- Set a default shell of a Bash login to automatically source the micromamba environment.
Test ROOT v6.24.x and v6.26.x and all compatible Python versions with them.
- Exclude versions of Python that are not compatible with ROOT releases.
- Test on macOS with the latest ROOT release on conda-forge (v6.26.x) and the latest supported CPython version (3.10).
Install ImageMagick and Ghostscript through conda-forge.
Remove commented out macOS and Python 2.7 workflows.

📚 Documentation preview 📚: https://hepdata-lib--220.org.readthedocs.build/en/220/

matthewfeickert · 2023-02-22T07:26:20Z

.github/workflows/tests.yml

+          - root-version: "6.24.00"
+            python-version: "3.10"


ROOT v6.24.00 isn't compatible with modern Python.

matthewfeickert · 2023-02-22T07:27:02Z

.github/workflows/tests.yml

+          - root-version: "6.26.10"
+            python-version: "3.6"
+          - root-version: "6.26.10"
+            python-version: "3.7"


The conda-forge distribution of ROOT v6.26 isn't compatible with Pythons that are EOL or on the verge of EOL.

codecov-commenter · 2023-02-22T07:30:18Z

Codecov Report

Merging #220 (7fd168a) into master (3732906) will increase coverage by 0.20%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
+ Coverage   87.80%   88.01%   +0.20%     
==========================================
  Files           4        4              
  Lines         968      968              
  Branches      189      202      +13     
==========================================
+ Hits          850      852       +2     
+ Misses         86       85       -1     
+ Partials       32       31       -1

Flag	Coverage Δ
unittests-3.10	`88.01% <ø> (?)`
unittests-3.6	`87.66% <ø> (?)`
unittests-3.7	`87.66% <ø> (?)`
unittests-3.8	`87.80% <ø> (ø)`
unittests-3.9	`87.80% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
hepdata_lib/c_file_reader.py	`92.94% <0.00%> (+0.64%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

matthewfeickert · 2023-02-22T16:08:48Z

@clelange once PR #218 is merged I can rebase this and then it will be ready to go.

matthewfeickert · 2023-02-22T16:19:08Z

@clelange thanks for the fast review and merge of PR #218! This is now ready for review. 👍

clelange

Thanks once more, this helps a lot! I left a couple of comments in the code. I hope the tests will answer some of my questions 😄

clelange · 2023-02-22T16:23:00Z

.github/workflows/tests.yml

@@ -22,15 +26,40 @@ jobs:
    strategy:
      matrix:
        os: [ubuntu-latest]
-        python-version: ["3.8"]
+        root-version: ["6.24.00", "6.26.10"]


Any reason not to go with the latest release of 6.24, i.e. 6.24.08?

Nope. That's fine to update to, I was just leaving this as it currently exists.

Instead of using == for ROOT I can also just use = and specifying down to the minor version (which with conda is the same as ~= x.y.0) though ROOT doesn't really follow SemVer and so there is no reason to trust that testing against the latest patch release won't break something for an unclear reason. But maybe that's better to catch anyway as it is better to know in CI that things are broken than finding out later.

.github/workflows/tests.yml

* Use the mamba-org/provision-with-micromamba GitHub action to setup a micromamba enviroment with a ROOT version and CPython version defined by the CI matrix. - Set a default shell of a Bash login to automatically source the micromamba environment. * Test ROOT v6.24.x and v6.26.x and all compatible Python versions with them. - Exclude versions of Python that are not compatible with ROOT releases. - Test on macOS with the latest ROOT release on conda-forge (v6.26.x) and the latest supported CPython version (3.10). * Install ImageMagick and Ghostscript through conda-forge. * Remove commented out macOS and Python 2.7 workflows.

matthewfeickert · 2023-02-22T16:58:37Z

.github/workflows/tests.yml

+        environment-name: ci
+        extra-specs: |
+          python=${{ matrix.python-version }}
+          root=${{ matrix.root-version }}


Using 6.24 and 6.26 along with root= instead of root== means that this is asking conda-forge for something equivalent to ~=6.26.0 in pip, for 6.26 for example.

That sounds good! Would you mind changing to =?

It already does use =.

Sorry, I see it now, was looking at an outdated diff for some reason...

matthewfeickert · 2023-02-22T16:59:45Z

.github/workflows/tests.yml

+        include:
+          - os: macos-latest
+            root-version: "6.26"
+            python-version: "3.10"


This adds back in macOS tests but just for the latest release, as macos-latest is much slower given the limited number of runners and high demands that GitHub has.

clelange

Thanks again! I'll merge this and will then make a new release so that python 2 can then be deprecated.

clelange · 2023-02-23T07:58:14Z

.github/workflows/tests.yml

+        environment-name: ci
+        extra-specs: |
+          python=${{ matrix.python-version }}
+          root=${{ matrix.root-version }}


Sorry, I see it now, was looking at an outdated diff for some reason...

matthewfeickert · 2023-02-23T08:05:02Z

Thanks again! I'll merge this and will then make a new release so that python 2 can then be deprecated.

If you want to make a release before removing Python 2 support then let me make a PR that adds a python_requires (PR #222) before you make the release so that this release gets that. I would also recommend making a minor release after PR #221 to signify that a Python version has been dropped.

matthewfeickert commented Feb 22, 2023

View reviewed changes

matthewfeickert force-pushed the ci/use-micromamba-provision branch from 7508ce5 to 7fd168a Compare February 22, 2023 16:17

matthewfeickert marked this pull request as ready for review February 22, 2023 16:18

clelange mentioned this pull request Feb 22, 2023

Drop Python 2 support #219

Closed

clelange requested changes Feb 22, 2023

View reviewed changes

matthewfeickert force-pushed the ci/use-micromamba-provision branch from 7fd168a to ca30b85 Compare February 22, 2023 16:42

matthewfeickert force-pushed the ci/use-micromamba-provision branch from ca30b85 to b110f0a Compare February 22, 2023 16:55

matthewfeickert commented Feb 22, 2023

View reviewed changes

matthewfeickert requested a review from clelange February 22, 2023 17:00

matthewfeickert mentioned this pull request Feb 23, 2023

build: Require Python 3.6+ for install #221

Merged

clelange approved these changes Feb 23, 2023

View reviewed changes

clelange merged commit 21349a6 into HEPData:master Feb 23, 2023

matthewfeickert deleted the ci/use-micromamba-provision branch February 23, 2023 08:03

This was referenced Feb 23, 2023

build: Add requires-python metadata #222

Merged

WIP: revive macOS CI #171

Closed

matthewfeickert mentioned this pull request Mar 8, 2023

Necessary dependencies to run full validation vs. validation with just ROOT MadAnalysis/madanalysis5#179

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: Use micromamba to test Python and ROOT #220

ci: Use micromamba to test Python and ROOT #220

matthewfeickert commented Feb 22, 2023 •

edited

Loading

matthewfeickert Feb 22, 2023

matthewfeickert Feb 22, 2023

codecov-commenter commented Feb 22, 2023 •

edited

Loading

matthewfeickert commented Feb 22, 2023

matthewfeickert commented Feb 22, 2023

clelange left a comment

clelange Feb 22, 2023

matthewfeickert Feb 22, 2023

matthewfeickert Feb 22, 2023

clelange Feb 23, 2023

matthewfeickert Feb 23, 2023

clelange Feb 23, 2023

matthewfeickert Feb 22, 2023

clelange left a comment

clelange Feb 23, 2023

matthewfeickert commented Feb 23, 2023 •

edited

Loading

ci: Use micromamba to test Python and ROOT #220

ci: Use micromamba to test Python and ROOT #220

Conversation

matthewfeickert commented Feb 22, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Feb 22, 2023 • edited Loading

Codecov Report

matthewfeickert commented Feb 22, 2023

matthewfeickert commented Feb 22, 2023

clelange left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

clelange left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matthewfeickert commented Feb 23, 2023 • edited Loading

matthewfeickert commented Feb 22, 2023 •

edited

Loading

codecov-commenter commented Feb 22, 2023 •

edited

Loading

matthewfeickert commented Feb 23, 2023 •

edited

Loading