-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maint: update API to conform to new pyuvdata conventions. #99
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@bhazelton I've tagged you on review in case you want to see some of these updates in action. These tests will not pass until the PR RadioAstronomySoftwareGroup/pyuvdata#1496 is merged though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, that this took me so long to get to! All of these changes look reasonable to me! Thanks for the edits, @steven-murray
Just realized that the tests are failing because the beam updates from |
@tyler-a-cox I think it's easier if we just wait til the next version comes out. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 97.85% 98.00% +0.14%
==========================================
Files 21 22 +1
Lines 838 900 +62
Branches 93 94 +1
==========================================
+ Hits 820 882 +62
Misses 9 9
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Description
This updates several internal APIs to use the new
AnalyticBeam
andBeamInterface
objects that came with pyuvdata 3.1.0.The user-facing API should be essentially unchanged, except that it is now allowed to pass
BeamInterface
objects in thebeams
parameter ofsimulate()
andsimulate_vis()
.EDIT: there is one API breaking change to
prepare_unpolarized_beam
. The parameteruse_pol
has changed touse_feed
, which is more general. This function is not really considered a core part of the API, so updating it should be fine.Checklist
I have