Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The timedata class function save() should return a path object and not a string #116

Closed
ehsteve opened this issue May 20, 2024 · 2 comments
Assignees

Comments

@ehsteve
Copy link
Member

ehsteve commented May 20, 2024

Our standard is to use paths everywhere instead of strings to have more portable code.

The title is self explanatory. This would make it easier to test whether a file was created by using the function is_file for example.

@ehsteve ehsteve changed the title The timedata class function save should return a path object and not a string The timedata class function save() should return a path object and not a string May 20, 2024
@Alrobbertz
Copy link
Member

I have completed and merged the required changes in Core through #117 .

I have shown that the changes work for the instrument repositories though EEA HERMES-SOC/hermes_eea#41. I will replicate these changes for the other instrument repos and merge them all at the same time.

@Alrobbertz
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants