Updates to use Pathlib rather than str or os.path #41
Conversation
|
The processed files are available as an artifact: https://github.com/HERMES-SOC/hermes_eea/actions/runs/9214426456/artifacts/1532606045 |
|
The processed files are available as an artifact: https://github.com/HERMES-SOC/hermes_eea/actions/runs/9214426456/artifacts/1545710270 |
|
The processed files are available as an artifact: https://github.com/HERMES-SOC/hermes_eea/actions/runs/9275854063/artifacts/1545832856 |
Co-authored-by: Damian Barrous Dume <damianbarrous@gmail.com>
|
The processed files are available as an artifact: https://github.com/HERMES-SOC/hermes_eea/actions/runs/9288106992/artifacts/1548724799 |
|
The processed files are available as an artifact: https://github.com/HERMES-SOC/hermes_eea/actions/runs/9372031922/artifacts/1567990823 |
|
The processed files are available as an artifact: https://github.com/HERMES-SOC/hermes_eea/actions/runs/9372099408/artifacts/1568006420 |
This PR updates the HERMES EEA processing functionality to consistently use
pathlib.Pathobjects for file paths when processing files. Previously these functions usedstrobjects oros.path, which goes against the HERMES best-practices. This PR aligns the functionality of the package with the best practices defined for the mission code development.This PR and HERMES-SOC/hermes_core#117 are co-dependent so we need to decide which we want to complete first. My recommendation would be to complete the Core PR first.
I've manually tested the
sdc_aws_processing_lambda, combining changes from both PRs , and successfully generated a CDF file.