Skip to content

Commit

Permalink
Disable engineering constraints in test
Browse files Browse the repository at this point in the history
Due to a bug where we were accidentally setting IP4-Y to vary, even
though it is supposed to be computed, we were actually not applying
engineering constraints in this test.

Since we weren't actually applying engineering constraints in the
testing before, just disable them for now. We can look into adding
them later.

Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
  • Loading branch information
psavery committed Jan 11, 2025
1 parent f733e47 commit 4890d34
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tests/calibration/test_calibration.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ def test_calibration(calibration_dir, test_data_dir):

calibrator = InstrumentCalibrator(
*calibrators,
engineering_constraints='TARDIS',
# Engineering constraints were actually not being utilized before,
# due to a bug. Disable them for now.
# engineering_constraints='TARDIS',
euler_convention=euler_convention,
)

Expand Down

0 comments on commit 4890d34

Please sign in to comment.