Take into account radius for calibration params #745
Merged
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For cylindrical detectors, we need to take into account the radius for calibration flags and parameters. This uses the old, non-lmfit style for defining calibration flags and parameters. We will be able to eliminate all of this when we upgrade the HEDM calibration to use the new lmfit calibration style... But for now, we need to maintain this. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
==========================================
- Coverage 39.70% 39.69% -0.01%
==========================================
Files 135 135
Lines 22392 22397 +5
==========================================
+ Hits 8890 8891 +1
- Misses 13502 13506 +4 ☔ View full report in Codecov by Sentry. |
The expression indicates that the parameter is computed, and thus should not be allowed to vary. This prevents an issue where, if the Y value of 'IMAGE-PLATE-4' for TARDIS was allowed to vary using the old parameter flags, and TARDIS engineering constraints are used such that the Y value of 'IMAGE-PLATE-4' is computed, that we won't accidentally set that parameter to vary. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Due to a bug where we were accidentally setting IP4-Y to vary, even though it is supposed to be computed, we were actually not applying engineering constraints in this test. Since we weren't actually applying engineering constraints in the testing before, just disable them for now. We can look into adding them later. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cylindrical detectors, we need to take into account the radius for calibration flags and parameters.
This uses the old, non-lmfit style for defining calibration flags and parameters. We will be able to eliminate all of this when we upgrade the HEDM calibration to use the new lmfit calibration style...
But for now, we need to maintain this.