Odds #7
Merged
Odds #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejmahler
reviewed
Jan 15, 2021
| // create an FFT | ||
| let r2c = real_planner.plan_fft_forward(length); | ||
| // make input and output vectors | ||
| let mut indata = r2c.make_input_vec(); |
There was a problem hiding this comment.
Yes I think this is quite convenient, so avoid writing the same "let blahblah = vec![.....]" over and over. Something you would like to have in RustFFT as well?
ejmahler
reviewed
Jan 15, 2021
src/lib.rs
Outdated
| } | ||
| } | ||
| impl<T: FftNum> RealToComplex<T> { | ||
| /// Create a new RealToComplex FFT for input data of a given length. Returns an error if the length is not even. |
There was a problem hiding this comment.
This comment isn't accurate anymore, since it always returns Ok()
There was a problem hiding this comment.
That looks as it's not from the latest version, this part changed a lot in the next couple of commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for odd lengths.
Also a big rewrite to be more similar to RustFFT, with a Planner etc.