Feedback from PR

* Deploy to sandbox * Attachments edit link goes to correct page * Resources data types change to array of text instead of array of strings
HHS · Mar 9, 2021 · 3050a42 · 3050a42
1 parent 77173a4
commit 3050a42
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -133,7 +133,7 @@ parameters:
     default: "main"
     type: string
   sandbox_git_branch:  # change to feature branch to test deployment
-    default: "grantee-import-bugfix"
+    default: "js-283-frontend-updates"
     type: string
 jobs:
   build_and_lint:

diff --git a/frontend/src/pages/ActivityReport/Pages/topicsResources.js b/frontend/src/pages/ActivityReport/Pages/topicsResources.js
@@ -150,7 +150,7 @@ const ReviewSection = () => {
       <Section
         hidePrint={!hasAttachments}
         key="Attachments"
-        basePath="attachments"
+        basePath="topics-resources"
         anchor="attachments"
         title="Attachments"
       >

diff --git a/src/migrations/20210302170502-add-resources-to-activity-report.js b/src/migrations/20210302170502-add-resources-to-activity-report.js
@@ -5,13 +5,13 @@ module.exports = {
         queryInterface.addColumn('ActivityReports',
           'nonECLKCResourcesUsed',
           {
-            type: Sequelize.ARRAY(Sequelize.STRING),
+            type: Sequelize.ARRAY(Sequelize.TEXT),
           }, { transaction }),
         queryInterface.removeColumn('ActivityReports', 'resourcesUsed', { transaction }),
         queryInterface.addColumn('ActivityReports',
           'ECLKCResourcesUsed',
           {
-            type: Sequelize.ARRAY(Sequelize.STRING),
+            type: Sequelize.ARRAY(Sequelize.TEXT),
           }, { transaction }),
       ]);
     });