Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-3102] Temporarily disable resource scrape job #2220

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

AdamAdHocTeam
Copy link
Collaborator

@AdamAdHocTeam AdamAdHocTeam commented Jun 20, 2024

Description of change

Temporarily disable the resource scrape job.

NOTE: This isn't something we are moving forward with ATM just want to have it reviewed in case we decide to move forward.

How to test

  • Make sure all tests pass and you can add resources to objectives without issue.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@AdamAdHocTeam AdamAdHocTeam marked this pull request as ready for review June 21, 2024 17:50
@GarrettEHill
Copy link
Contributor

I don't this disabling this will provide any value, I think we should hold off from merging this.

@AdamAdHocTeam
Copy link
Collaborator Author

I don't this disabling this will provide any value, I think we should hold off from merging this.

Yes as we discussed this isn't something we are moving forward with ATM (see the note in the description).

Copy link
Collaborator

@thewatermethod thewatermethod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing seems broken

@AdamAdHocTeam AdamAdHocTeam merged commit a969066 into main Jul 9, 2024
10 checks passed
@AdamAdHocTeam AdamAdHocTeam deleted the al-ttahub-3102-disable-scrape branch July 9, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants