[TTAHUB-3192] Fetch topics separately for RTTAPA #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewatermethod
commented
Jul 17, 2024
| @@ -486,7 +486,7 @@ function calculatePreviousStatus(goal) { | |||
| // otherwise we check to see if there is the goal is on an activity report, | |||
| // and also check the status | |||
| if (goal.objectives.length) { | |||
| const onAr = goal.objectives.some((objective) => objective.activityReports.length); | |||
| const onAr = goal.objectives.some((objective) => objective.onApprovedAR); | |||
There was a problem hiding this comment.
This is just a convenience (we already had the flag in the query)
thewatermethod
commented
Jul 17, 2024
| include: [ | ||
| { | ||
| model: Topic, | ||
| through: [], |
There was a problem hiding this comment.
through and separate don't play nice
thewatermethod
commented
Jul 17, 2024
| @@ -733,25 +734,6 @@ export async function getGoalsByActivityRecipient( | |||
| where: { | |||
| calculatedStatus: REPORT_STATUSES.APPROVED, | |||
| }, | |||
| include: [ | |||
There was a problem hiding this comment.
This doesn't seem necessary
thewatermethod
requested review from
nvms,
GarrettEHill,
kryswisnaskas and
AdamAdHocTeam
nvms
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fetch topics data on the RTTAPA with Sequelize's
separate: trueflag, since the current way seems to run up against some limit with certain recipients.How to test
Confirm the RTTAPA cards display the correct topics. Open the case from the support ticket. Confirm that the recipient is visible and that the goal query doesn't time out and display an error in the front end.
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy