Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs found during accessibility review #2384

Merged
merged 6 commits into from
Sep 30, 2024

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Sep 23, 2024

Description of change

Fix issues found during accessibility review:

  • Resource repeater should use dynamic error text insertion instead of conditionally displaying the error message, since browsers only read off updates to elements with role alert and not creation
  • Fixes a bug with disappearing root causes on FEI goals created on AR
  • Fixes a bug with an input not properly associated with a label

How to test

  • Confirm that the resource repeater error is announced
  • Confirm that creating an FEI goal on an activity report allows you to edit the root causes
  • Confirm that the event creator has a label "for" matching the input id

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod merged commit 25435c5 into main Sep 30, 2024
10 checks passed
@thewatermethod thewatermethod deleted the mb/fix-accessibility-review-bugs branch September 30, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants