Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Remove unnecessary src/.eslintrc and frontend/src/.eslintrc #2400

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

nvms
Copy link
Collaborator

@nvms nvms commented Oct 7, 2024

Description of change

We store our eslint configs in package.json and frontend/package.json, so we don't also need src/.eslintrc and frontend/src/.eslintrc. It is safe to remove these.

Further, on my machine at least, it confuses the eslint LSP (vscode-eslint-language-server) which apparently prioritizes the discovery of .eslintrc over a package.json configuration, discovers no configuration (because these files are empty) and therefore provides no diagnostics.

How to test

Make sure eslint still provides diagnostics in your editor.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@nvms nvms changed the base branch from main to yarn-audit-ignore-cookie October 7, 2024 13:15
@nvms nvms changed the base branch from yarn-audit-ignore-cookie to main October 7, 2024 13:16
@nvms nvms marked this pull request as ready for review October 7, 2024 15:39
Copy link
Collaborator

@GarrettEHill GarrettEHill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this works now

@nvms nvms merged commit a80b58f into main Oct 7, 2024
10 checks passed
@nvms nvms deleted the jp/rm-eslintrc branch October 7, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants