Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-3452] Fix comm date validation #2402

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

thewatermethod
Copy link
Collaborator

Description of change

The issue here is that the validation on the frontend (can we parse a valid date from what the user enters using the momentjs library?) normally combines with postgres date columns to standardize the saved format. Since we are saving the date here to a JSON field, the date field can contain any arbitrary value that moment can figure out. This change preempts the save and create communication log services to use moment's formatting to save whatever date it has parsed from user input.

How to test

Save a date in a non MM/DD/YYYY format in the communication date field in the comm log. Save: the value in the UI and the database is corrected.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod marked this pull request as ready for review October 9, 2024 17:46
@GarrettEHill
Copy link
Collaborator

that seems to be the fix for https://jira.acf.gov/browse/TTAHUB-3453

@thewatermethod thewatermethod merged commit 58e6f3e into main Oct 15, 2024
10 checks passed
@thewatermethod thewatermethod deleted the mb/TTAHUB-3452/force-standard-communication-date branch October 15, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants