Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Change checkbox label to "OHS standard goals," fix accessibility issues with table, fix accessibility issues with admin TR form #2416

Merged
merged 18 commits into from
Oct 17, 2024

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Oct 17, 2024

Description of change

  • On the RTR, the checkbox that said "Use OHS initiative goal" now reads "Use OHS standard goal"
  • Fix aria labels on Horizontal Table Widget for a much improved screen-reader experience
  • Fix validation issues with the admin version of the TR form

How to test

  • Confirm that event collaborators and regional point of contact fields are validated on blur if a selection was not made (as an admin on the TR form)
  • Confirm hidden labels on Horizontal Table Widget for select row checkboxes and table headers are human-understandable
  • Confirm that the checkbox now reads "Use OHS standard goal"

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod marked this pull request as ready for review October 17, 2024 13:59
@Jones-QuarteyDana Jones-QuarteyDana merged commit 539a2ec into production Oct 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants