Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-2549] Minimal Default Docker Configuration #2417

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

GarrettEHill
Copy link
Collaborator

Description of change

  • Changed yarn docker:start to only run the minimal required containers.
  • Added yarn docker:start:full to run all the containers
  • switch from docker-compose to docker compose

How to test

run the yarn commands

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@GarrettEHill GarrettEHill marked this pull request as ready for review October 18, 2024 07:54
Copy link
Collaborator

@nvms nvms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

https://github.com/HHS/Head-Start-TTADP/blob/TTAHUB-2549%2Fminimal-required/README.md#L90-L92

I think this will need to be re-worded/removed since we would no longer require docker-compose.

Edit: looks like that link doesn't actually take you to those lines... but it's this bit right here:

On a Mac with Brew installed Docker, yarn commands may fail due to the absence of `docker-compose` (vs `docker compose`).  To resolve:

`brew install docker-compose` 

Copy link
Collaborator

@thewatermethod thewatermethod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, awesome change

@GarrettEHill GarrettEHill merged commit e588849 into main Oct 23, 2024
0 of 2 checks passed
@GarrettEHill GarrettEHill deleted the TTAHUB-2549/minimal-required branch October 23, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants