Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Code coverage, accessibility fixes, software updates #2516

Merged
merged 78 commits into from
Dec 5, 2024

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Dec 4, 2024

Description of change

This PR includes an assortment of fixes, updates, and added code coverage. It also deploys the frontend of the monitoring RTR tab behind a feature flag so that it can undergo the first stage of design review.

Accessibility

  • [TTAHUB-3437] Modals should be immediately after the control that spawned them
  • [TTAHUB-3444] Drawers should trap focus

Modals should be next in the document from the controls that spawn them, so that when focus is returned to the DOM, it returns to approximately the same place

It should be impossible to "tab" out of drawers

Code coverage

  • [TTAHUB-3569] Coverage >= 90% src/middleware/authMiddleware.js
  • [TTAHUB-3546] Coverage >= 90%: src/scopes/trainingReports utils.js & startDate.js
  • [TTAHUB-3567] Coverage >= 90% src/policies/sessionReport.js
  • [TTAHUB-3566] Coverage >= 90% src/policies/group.js
  • [TTAHUB-3561] Coverage >= 90% src/routes/goalTemplates/handlers.js
  • [TTAHUB-3439] Coverage >= 90% src/goalServices/reduceGoals.js

Devops

  • [TTAHUB-3063] Deploy processed data to lower environments
  • [TTAHUB-3676] update cf cli tools for deployment from v7 to v8
  • [TTAHUB-3675] Update node from 18.20.3 to 18.20.4

How to test

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

nvms and others added 25 commits December 4, 2024 11:02
…coverage

[TTAHUB-3561] Coverage >= 90% src/routes/goalTemplates/handlers.js
[TTAHUB-3566] Coverage >= 90% src/policies/group.js
…verage

[TTAHUB-3567] Coverage  >= 90% src/policies/sessionReport.js
[TTAHUB-3546] Coverage >= 90%: src/scopes/trainingReports utils.js & startDate.js
[TTAHUB-3569] Coverage >= 90% src/middleware/authMiddleware.js
[TTAHUB-3063] Deploy processed data to lower environments
[TTAHUB-3439] Coverage >= 90%: src/goalServices/reduceGoals.js
[TTAHUB-3444] Prevent clicking out of drawers
@thewatermethod thewatermethod marked this pull request as ready for review December 5, 2024 17:01
@Jones-QuarteyDana Jones-QuarteyDana merged commit f12d36f into production Dec 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants