Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft alert and report bug fixes #390

Merged
merged 10 commits into from
Mar 16, 2021
Merged

Draft alert and report bug fixes #390

merged 10 commits into from
Mar 16, 2021

Conversation

jasalisbury
Copy link
Contributor

@jasalisbury jasalisbury commented Mar 15, 2021

375

Description of change
Alert is shown after a draft is saved

Also fixed two bugs related to page state

  1. Pages would set their state to the page they switch to. So if I browsed to a Not Started page from a Completed page that Not Started would be set to Completed after browsing away, even if the page was not completed.
  2. Switching between grantee/non-grantee didn't properly handle the state of the activity summary page

How to test

  1. Pull down changes
  2. Save draft reports to make sure the "save draft" dialog works
  3. Save and browse pages to make sure page state is updated correctly

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

389

Description of change

  • Only include active grants in the possible recipients list. We're importing inactive grants now so we need to filter them out
  • Create non-grantee recipients in a migration, so they're available in staging and production

How to test

  • Agency 1.b should no longer appear in the list of grantees in region 1

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

Also fixed two bugs related to page state

1) Pages would set their state to the page they switch to. So if I
browse to a Not Started page from a Completed page that Not Started
would be set to Completed after browsing away.
2) Switching between grantee/non-grantee didn't properly handle the
state of the activity summary page
The switch to rerender the navigator means state has to live up one
level
…d-Start-TTADP into js-375-alert-on-draft-save
@jasalisbury jasalisbury requested a review from rahearn March 15, 2021 23:53
Copy link
Contributor

@rahearn rahearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rahearn rahearn merged commit 57e3152 into HHS:main Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity Recipient tweaks Add alert after user saves draft
2 participants