Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test that covers select all/clear all filter options #2144

Closed
acouch opened this issue Sep 17, 2024 · 0 comments · Fixed by #3319
Closed

Add e2e test that covers select all/clear all filter options #2144

acouch opened this issue Sep 17, 2024 · 0 comments · Fixed by #3319
Assignees
@doug-s-nava
Labels
Migrated

Comments

@acouch
Copy link
Collaborator

acouch commented Sep 17, 2024

Migrated from navapbc#79
Originally created by @rylew1 on Wed, 12 Jun 2024 17:25:28 GMT

Summary

The select all / clear all functionality is complex and is not perfectly covered at the moment.

  • test on funding instrument, eligibility, agency, category (could be multiple e2e tests in their own describe block)
  • select all / clear all on agency should work at both the global filter level, and the individual section level
  • assert that the counts are properly displayed at the global and section level
  • extra credit: load the page with query params and make relevant assertions

Acceptance criteria

e2e test(s) covers filter select all / clear all functionality
@acouch acouch mentioned this issue Sep 17, 2024
Closed
@acouch acouch added this to the Search UI - Enhancements and fast follow milestone Sep 20, 2024
@mxk0 mxk0 changed the title [Task]: Add e2e test that covers select all/clear all filter options Add e2e test that covers select all/clear all filter options Sep 30, 2024
@margaretspring margaretspring removed this from the Search UI - Enhancements and fast follow milestone Oct 22, 2024
@mxk0 mxk0 moved this from Icebox to Todo in Simpler.Grants.gov Product Backlog Nov 15, 2024
@doug-s-nava doug-s-nava moved this from Todo to In Progress in Simpler.Grants.gov Product Backlog Dec 18, 2024
@doug-s-nava doug-s-nava self-assigned this Dec 18, 2024
@doug-s-nava doug-s-nava mentioned this issue Dec 19, 2024
Merged
@doug-s-nava doug-s-nava moved this from In Progress to In Review in Simpler.Grants.gov Product Backlog Dec 20, 2024
doug-s-nava added a commit that referenced this issue Dec 30, 2024
@doug-s-nava
[Issue #2144] e2e tests for clear/select all filters and fix nested f…
257b7cf 
…ilter bug (#3319)

* adds e2e tests for "select all" and "clear all" filter functionality, including for agencies / nested filters
* fixes bugs with nested filters that showed incorrect selected filter counts and did not correctly clear selected filters
doug-s-nava added a commit that referenced this issue Dec 30, 2024
@doug-s-nava
[Issue #2144] e2e tests for clear/select all filters and fix nested f…
e24ca29 
…ilter bug (#3319)

* adds e2e tests for "select all" and "clear all" filter functionality, including for agencies / nested filters
* fixes bugs with nested filters that showed incorrect selected filter counts and did not correctly clear selected filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doug-s-nava doug-s-nava

Labels
Migrated
Projects
Simpler.Grants.gov Product Backlog
Status: Done
SimplerGrants Product Backlog (experiment to be deleted)
Status: Todo
Milestone
No milestone
3 participants
@acouch @margaretspring @doug-s-nava